Bug 20585 - Label surname as name for organisation type patrons
Summary: Label surname as name for organisation type patrons
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Josef Moravec
URL:
Keywords:
: 20983 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-04-15 09:37 UTC by Katrin Fischer
Modified: 2019-10-14 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20585: Label surname as name for organisation type patrons (1.70 KB, patch)
2018-06-25 14:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 20585: Label surname as name for organisation type patrons (1.76 KB, patch)
2018-06-25 21:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20585: Label surname as name for organisation type patrons (1.81 KB, patch)
2018-06-27 12:19 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-04-15 09:37:42 UTC
I would be nice to consistently label 'surname' as 'name' for patrons of an organisation type category.

- when adding/editing a patron of this type
- on details tab
- ...
Comment 1 Owen Leonard 2018-06-25 14:15:05 UTC
Created attachment 76379 [details] [review]
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.
Comment 2 Owen Leonard 2018-06-25 14:18:07 UTC
*** Bug 20983 has been marked as a duplicate of this bug. ***
Comment 3 Katrin Fischer 2018-06-25 20:45:54 UTC
With the patch surname will always be required for organisation type patrons, which makes sense.
Comment 4 Katrin Fischer 2018-06-25 21:03:54 UTC
Created attachment 76419 [details] [review]
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Josef Moravec 2018-06-27 12:19:37 UTC
Created attachment 76483 [details] [review]
Bug 20585: Label surname as name for organisation type patrons

This patch modifies the patron edit page so that the label for an
organization name is "Name" instead of "Surname."

To test, apply the patch and edit both an institutional patron and a
regular patron. Confirm that the name/surname label is correct in each
case.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Nick Clemens 2018-06-29 21:04:16 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-07-02 09:14:28 UTC
Enhancement, not backporting to 18.05.x branch.