Bug 20599 - Add the Koha::Subscription->vendor method
Summary: Add the Koha::Subscription->vendor method
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 18426
  Show dependency treegraph
 
Reported: 2018-04-17 21:12 UTC by Jonathan Druart
Modified: 2018-04-19 15:43 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20599: Add the Koha::Subscription->vendor method (2.66 KB, patch)
2018-04-17 21:13 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20599: Add the Koha::Subscription->vendor method (2.88 KB, patch)
2018-04-18 01:21 UTC, M. Tompsett
Details | Diff | Splinter Review
Bug 20599: Add the Koha::Subscription->vendor method (2.94 KB, patch)
2018-04-18 06:06 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-04-17 21:12:37 UTC
To access the vendor of a subscription easily
Comment 1 Jonathan Druart 2018-04-17 21:13:24 UTC
Created attachment 74392 [details] [review]
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green
Comment 2 M. Tompsett 2018-04-18 01:21:38 UTC
Created attachment 74401 [details] [review]
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

NOTE: My preference is for $subscription to be object,
      and perhaps something like $built_subscription to
      be from the builder. Because, $object is a poor
      variable name.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Comment 3 Katrin Fischer 2018-04-18 06:06:09 UTC
Created attachment 74403 [details] [review]
Bug 20599: Add the Koha::Subscription->vendor method

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

NOTE: My preference is for $subscription to be object,
      and perhaps something like $built_subscription to
      be from the builder. Because, $object is a poor
      variable name.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Jonathan Druart 2018-04-19 15:43:08 UTC
Pushed to master for 18.05, thanks to everybody involved!