Bug 20659 - Blocking errors are not longer displayed
Summary: Blocking errors are not longer displayed
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 18403
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-25 19:51 UTC by Jonathan Druart
Modified: 2018-04-25 19:53 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20659: Fix blocking errors display (1.45 KB, patch)
2018-04-25 19:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-04-25 19:51:55 UTC
The include file blocking-errors.inc has been created to by-pass regular processing and display an error that should block the elements of the view.

For instance you call a patron's page with invalid borrowernumber => we do not want the app to crash (500) or the page to display with broken elements.

It worked well on bug 18403 but it's now broken, a blank page is displayed instead.
It may be caused by the move of the JS to the bottom of the page.
Comment 1 Jonathan Druart 2018-04-25 19:53:08 UTC
Created attachment 74856 [details] [review]
Bug 20659: Fix blocking errors display

The include file blocking-errors.inc has been created to by-pass regular
processing and display an error that should block the elements of the
view.

For instance you call a patron's page with invalid borrowernumber => we
do not want the app to crash (500) or the page to display with broken
elements.

It worked well on bug 18403 but it's now broken, a blank page is
displayed instead.
It may be caused by the move of the JS to the bottom of the page.

Test plan:
hit /cgi-bin/koha/members/moremember.pl?borrowernumber=45432
Without this patch a blank page is displayed.
With this patch you see the blocking error
Comment 2 Jonathan Druart 2018-04-25 19:53:55 UTC
Patch pushed to master for 18.05