Bug 20737 - Use https for Baker and Taylor cover images
Summary: Use https for Baker and Taylor cover images
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-05-09 11:50 UTC by Nick Clemens
Modified: 2018-05-11 17:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20737: Use https for baker and taylor cover images (4.19 KB, patch)
2018-05-09 11:54 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 20737: Use https for baker and taylor cover images (4.25 KB, patch)
2018-05-10 15:57 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 20737: Use https for baker and taylor cover images (4.36 KB, patch)
2018-05-11 06:27 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-05-09 11:50:06 UTC

    
Comment 1 Nick Clemens 2018-05-09 11:54:15 UTC
Created attachment 75204 [details] [review]
Bug 20737: Use https for baker and taylor cover images

Easy change, should be able to verify with code review or testing with
dummy values

To test:
1 - Put some values in baker and taylor prefs (don't need to be valid)
2 - Do a search on the opac (and have some items with isbns)
3 - Inspect the cover images links to ensure they are formed correctly
4 - prove -v t/External/BakerTaylor.t
Comment 2 Katrin Fischer 2018-05-10 15:57:35 UTC
Created attachment 75230 [details] [review]
Bug 20737: Use https for baker and taylor cover images

Easy change, should be able to verify with code review or testing with
dummy values

To test:
1 - Put some values in baker and taylor prefs (don't need to be valid)
2 - Do a search on the opac (and have some items with isbns)
3 - Inspect the cover images links to ensure they are formed correctly
4 - prove -v t/External/BakerTaylor.t

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Marcel de Rooy 2018-05-11 06:24:24 UTC
Hmm, hardcoded URLs like http://contentcafe2.btol.com in various scripts.
I do not object to pushing this fix, but it would be better to remove them from the code and put them somewhere else (pref, koha-conf, etc.)
Comment 4 Marcel de Rooy 2018-05-11 06:27:27 UTC
Created attachment 75250 [details] [review]
Bug 20737: Use https for baker and taylor cover images

Easy change, should be able to verify with code review or testing with
dummy values

To test:
1 - Put some values in baker and taylor prefs (don't need to be valid)
2 - Do a search on the opac (and have some items with isbns)
3 - Inspect the cover images links to ensure they are formed correctly
4 - prove -v t/External/BakerTaylor.t

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Jonathan Druart 2018-05-11 17:12:54 UTC
Pushed to master for 18.05, thanks to everybody involved!