Bug 20764 - t/Koha_Template_Plugin_KohaPlugins.t is DB dependent
Summary: t/Koha_Template_Plugin_KohaPlugins.t is DB dependent
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Target Milestone: ---
Assignee: Mirko Tietgen
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 20181
Blocks: 21352
  Show dependency treegraph
 
Reported: 2018-05-14 13:07 UTC by Mirko Tietgen
Modified: 2018-10-19 08:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 20764: Koha_Template_Plugin_KohaPlugins.t is db dependent (758 bytes, patch)
2018-05-14 13:13 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 20764: (QA follow-up) Fix path to sample plugins (1.42 KB, patch)
2018-05-14 15:04 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20764: (QA follow-up) Fix path to sample plugins (2.16 KB, patch)
2018-05-14 15:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 20764: Rename the test file (730 bytes, patch)
2018-05-14 15:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20764: (follow-up) Rename the test file (897 bytes, patch)
2018-05-14 15:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20764: Fix Plugins.t (780 bytes, patch)
2018-05-14 16:10 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mirko Tietgen 2018-05-14 13:07:15 UTC
t/Koha_Template_Plugin_KohaPlugins.t is DB dependent. This patch moves it to t/db_dependent/
Comment 1 Mirko Tietgen 2018-05-14 13:13:13 UTC
Created attachment 75303 [details] [review]
Bug 20764: Koha_Template_Plugin_KohaPlugins.t is db dependent

t/Koha_Template_Plugin_KohaPlugins.t is DB dependent.
This patch moves it to t/db_dependent/
Comment 2 Jonathan Druart 2018-05-14 14:21:05 UTC
Pushed to master for 18.05, thanks Mirko!
Comment 3 Tomás Cohen Arazi 2018-05-14 15:04:02 UTC
Created attachment 75310 [details] [review]
Bug 20764: (QA follow-up) Fix path to sample plugins

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2018-05-14 15:10:21 UTC
Created attachment 75311 [details] [review]
Bug 20764: (QA follow-up) Fix path to sample plugins

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Jonathan Druart 2018-05-14 15:15:12 UTC
Created attachment 75314 [details] [review]
Bug 20764: Rename the test file
Comment 6 Jonathan Druart 2018-05-14 15:27:59 UTC
Last patches pushed to master.
Comment 7 Jonathan Druart 2018-05-14 15:34:16 UTC
Created attachment 75317 [details] [review]
Bug 20764: (follow-up) Rename the test file

There is something wrong here...
Comment 8 Jonathan Druart 2018-05-14 16:10:06 UTC
Created attachment 75318 [details] [review]
Bug 20764: Fix Plugins.t

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Fridolin SOMERS 2018-10-19 08:55:47 UTC
I've decided to backport to 17.11.x, this is very useful and not risky.

Pushed to 17.11.x for 17.11.11
Comment 10 Fridolin SOMERS 2018-10-19 08:56:06 UTC
Pushed to 17.11.x for 17.11.11