Bug 20963 - Can check out not for loan items when temporarily overriding restriction
Summary: Can check out not for loan items when temporarily overriding restriction
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-06-19 08:07 UTC by Katrin Fischer
Modified: 2018-06-19 19:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-06-19 08:07:29 UTC
If the user has a restriction (for example DISCHARGE) and you use the 'temporary override' button, it's possible to check out items with not for loan itemtypes. Even when AllowNotForLoanOverride is set to not allow override.
Comment 1 Jonathan Druart 2018-06-19 12:46:31 UTC
This sounds like a long standing bug.

It will be hard to deal with that bug, the permission { circulate => force_checkout } allows to force the checkout if the patron has a restriction. 

When the forceallow flag is set, all other Allow*Override prefs are bypassed.

I guess we should deal with the permissions differently than the Allow*Override prefs.
Comment 2 Katrin Fischer 2018-06-19 19:42:35 UTC
I think it's a mistake in the logic, the override for restriction should just allow you to 'unlock' the circulation, not override all other rules. But yeah, probably not an easy fix.