Bug 21032 - Refining a search made on a specific index fail
Summary: Refining a search made on a specific index fail
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Alex Arnaud
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-03 13:43 UTC by Alex Arnaud
Modified: 2018-07-12 10:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21032 - fix using facet for searches made on specific index (2.47 KB, patch)
2018-07-03 13:59 UTC, Alex Arnaud
Details | Diff | Splinter Review
Bug 21032 - fix using facet for searches made on specific index (2.62 KB, patch)
2018-07-12 10:40 UTC, Séverine Queune
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Arnaud 2018-07-03 13:43:19 UTC
Try a simple search like (OPAC or staff): title:foo.
Click on a facet: badaboum!
Comment 1 Alex Arnaud 2018-07-03 13:59:35 UTC
Created attachment 76653 [details] [review]
Bug 21032 - fix using facet for searches made on specific index

Test plan:

  - Try a simple search (OPAC or staff) like "title:foo",
  - click on a facet: badaboum!
  - apply this patch,
  - retry
Comment 2 Séverine Queune 2018-07-03 15:30:40 UTC
Thanks for this patch !
It works correctly except when facets end with punctuation.
Status set to 'Failed', sorry Alex :(
Comment 3 Alex Arnaud 2018-07-04 08:53:23 UTC
(In reply to Séverine Queune from comment #2)
> Thanks for this patch !
> It works correctly except when facets end with punctuation.
> Status set to 'Failed', sorry Alex :(

Hello Séverine,

Thanks for testing!

In my opinion, this should be a separate bug.

But i'm not able to reproduce this issue. I have a search result with 2 different facets: "Pakita," and "Pakita". Clicking one or the other, it works and i get the same results for the two.
Comment 4 Séverine Queune 2018-07-12 10:40:34 UTC
Created attachment 76884 [details] [review]
Bug 21032 - fix using facet for searches made on specific index

Test plan:

  - Try a simple search (OPAC or staff) like "title:foo",
  - click on a facet: badaboum!
  - apply this patch,
  - retry

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 5 Séverine Queune 2018-07-12 10:42:23 UTC
Tested in our 2 different instances (dev and test) and both work !
The problem I mentioned on comment 2 seems to be specific to the sandbox.
Thank you Alex !