Broken in at least master and 18.05.
Created attachment 77460 [details] [review] Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch.
Created attachment 77468 [details] [review] Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch. https://bugs.koha-community.org/show_bug.cgi?id=21141 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Part of this fix is already in bug 19436. Waiting for a push too long already.
Created attachment 77551 [details] [review] Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(In reply to Marcel de Rooy from comment #3) > Part of this fix is already in bug 19436. Waiting for a push too long > already. I think this will be useful as a quick fix and for backporting to 18.05 as a bugfix. But also keen on the functionality of 19436 for 18.11.
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Patch was broken when resolving a conflict I guess, patch in master and 18.05 is NOT my patch. Instead of fixing, it now breaks everything.
Depends on Bug 19436 not in 17.11.x