Stems from bug 20660 The issue seems to be that $return_date is a string and not a DateTime object - when we call _debar_user_on_return we are expecting a DateTime object
Created attachment 77622 [details] [review] Bug 21188: Convert return_date to a DateTime object
(In reply to Nick Clemens from comment #1) > Created attachment 77622 [details] [review] [review] > Bug 21188: Convert return_date to a DateTime object To test: 1 - Checkout an item 2 - Make it over due: update issues set date_due='1999-01-01'; 3 - Go to 'Circulation->Check-in' 4 - Specify a return date 5 - Check in the item 6 - Internal server error 7 - Apply patch 8 - Repeat 1-5 9 - Success! 10 - prove t/db_dependent/Circulation/issue.t
Created attachment 77627 [details] [review] Bug 21188: Convert return_date to a DateTime object Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Minor fix, moving to PQA
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03