Bug 21229 - Correct nesting and specificity for some button styles
Summary: Correct nesting and specificity for some button styles
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 19474
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-15 13:12 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 21229: Correct nesting and specificity for some button styles (1.83 KB, patch)
2018-08-15 13:19 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 21229: Correct nesting and specificity for some button styles (1.89 KB, patch)
2018-08-16 07:07 UTC, Claire Gravely 		Details | Diff | Splinter Review
Bug 21229: Correct nesting and specificity for some button styles (1.89 KB, patch)
2018-08-16 20:01 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-08-15 13:12:58 UTC 
There is an error in the nesting and specificity of some Bootstrap button-related styles.
Comment 1 Owen Leonard 2018-08-15 13:19:08 UTC 
Created attachment 77814 [details] [review]
Bug 21229: Correct nesting and specificity for some button styles

This patch corrects some Bootstrap button-related CSS which was causing
some buttons to have the wrong color:

 - Circulation -> Check out: "Add a new message" link is black
 - Catalog -> Details page: "Print" button is blue

To test, apply the patch and rebuild CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Clear your browser cache if necessary and view the above pages to
confirm the problem is fixed.
Comment 2 Claire Gravely 2018-08-16 07:07:43 UTC 
Created attachment 77874 [details] [review]
Bug 21229: Correct nesting and specificity for some button styles

This patch corrects some Bootstrap button-related CSS which was causing
some buttons to have the wrong color:

 - Circulation -> Check out: "Add a new message" link is black
 - Catalog -> Details page: "Print" button is blue

To test, apply the patch and rebuild CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Clear your browser cache if necessary and view the above pages to
confirm the problem is fixed.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Katrin Fischer 2018-08-16 20:01:04 UTC 
Created attachment 77957 [details] [review]
Bug 21229: Correct nesting and specificity for some button styles

This patch corrects some Bootstrap button-related CSS which was causing
some buttons to have the wrong color:

 - Circulation -> Check out: "Add a new message" link is black
 - Catalog -> Details page: "Print" button is blue

To test, apply the patch and rebuild CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Clear your browser cache if necessary and view the above pages to
confirm the problem is fixed.

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 4 Nick Clemens (kidclamp) 2018-08-21 13:57:54 UTC 
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize (ashimema) 2018-08-24 10:03:05 UTC 
Caused by bug 19474 not in 18.05.x branch.