Bug 21278 - CANCEL_HOLD_ON_LOST notice contains different variables
Summary: CANCEL_HOLD_ON_LOST notice contains different variables
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-27 14:49 UTC by Caroline Cyr La Rose
Modified: 2019-10-14 19:58 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2018-08-27 14:49:42 UTC
The sample notice CANCEL_HOLD_ON_LOST contains variables with the syntax [% xxx %] instead of << xxx >>.

in installer/data/mysql/en/mandatory/sample_notices.sql
Comment 1 Katrin Fischer 2018-08-27 16:20:52 UTC
Hi Caroline, 

that's the new TT syntax - it should work. Have you tested?

The notice also uses an IF/ELSE construct to display the right reason, this would not be possible without TT (Template Toolkit)
Comment 2 Caroline Cyr La Rose 2018-08-27 16:25:27 UTC
Katrin,

I didn't test it, but I figured it might be confusing to end users if they see some notices have [% xxx %] and other notices have << xxx >>.

Either they should all be [% xxx %] or all << xxx >>, not a mix of the two.

If it is indeed changing, we have a lot of work to do in the manual and the wiki to change the instructions on how to customize the notices.
Comment 3 Katrin Fischer 2018-08-27 17:56:14 UTC
It's a process, I think starting with the new notices now. The account slip notices (payment/waive receipts) in 18.11 will also be TT from the start, as they make calculations and do formatting (look in master).

The old ones are supposed to be converted too, maybe this should be a goal for 18.11?

Look at the graph view of this bug:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279

There are 2 examples for converted notices here:
https://wiki.koha-community.org/wiki/Notices_and_Slips_Library
Comment 4 Jonathan Druart 2018-08-29 20:32:07 UTC
All new notices should use the TT syntax.