Bug 21333 - Add ability to add to basket from a file
Summary: Add ability to add to basket from a file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-11 16:27 UTC by Nick Clemens
Modified: 2019-10-14 19:58 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21333: Add ability to add to basket from a new file (5.60 KB, patch)
2018-09-11 16:31 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21333: Add ability to add to basket from a new file (5.64 KB, patch)
2018-09-14 20:06 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21333: Add ability to add to basket from a new file (5.68 KB, patch)
2018-09-15 16:27 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 21333: (follow-up) Make link a button (1.83 KB, patch)
2018-09-16 16:57 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21333: (follow-up) Make link a button (1.84 KB, patch)
2018-09-16 17:24 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 21333: Add ability to add to basket from a new file (5.78 KB, patch)
2018-09-21 21:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21333: (follow-up) Make link a button (1.92 KB, patch)
2018-09-21 21:15 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2018-09-11 16:27:58 UTC

    
Comment 1 Nick Clemens 2018-09-11 16:31:54 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens 2018-09-14 20:06:22 UTC
Created attachment 78725 [details] [review]
Bug 21333: Add ability to add to basket from a new file

This patch adds a workflow for adding to a basket from a file. It
removes the need to stage the file before going to the basket and allows
you to stage the file and return to the basket

To test:
1 - Have basket in acquissitions
2 - Click add to basket
3 - Note new option to 'Add from new file'
4 - Click it
5 - You will be sent to the record import tool
6 - Stage your file
7 - There is a link after staging 'Add records to basket'
8 - Click it
9 - Your items should be added
Comment 3 Koha Team University Lyon 3 2018-09-14 21:42:43 UTC
I have followed the test plan and try several times. 
On the basket - click on add a new file, then upload it and click on add the records on basket and then I retrieve it in the acquisitions module (in addorderiso2709 page) and then that's the process that we usually use.

It works as expected for me.
Comment 4 Biblibre Sandboxes 2018-09-15 16:27:12 UTC
Patch tested with a sandbox, by Sonia <sonia.bouis@univ-lyon3.fr>
Comment 5 Biblibre Sandboxes 2018-09-15 16:27:41 UTC
Created attachment 78854 [details] [review]
Bug 21333: Add ability to add to basket from a new file

This patch adds a workflow for adding to a basket from a file. It
removes the need to stage the file before going to the basket and allows
you to stage the file and return to the basket

To test:
1 - Have basket in acquissitions
2 - Click add to basket
3 - Note new option to 'Add from new file'
4 - Click it
5 - You will be sent to the record import tool
6 - Stage your file
7 - There is a link after staging 'Add records to basket'
8 - Click it
9 - Your items should be added

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>
Comment 6 Jonathan Druart 2018-09-15 19:00:52 UTC
Why did you put the link there?

https://snag.gy/5EBbq1.jpg
Comment 7 Nick Clemens 2018-09-16 16:57:02 UTC Comment hidden (obsolete)
Comment 8 Nick Clemens 2018-09-16 17:24:33 UTC
Created attachment 78952 [details] [review]
Bug 21333: (follow-up) Make link a button
Comment 9 Jonathan Druart 2018-09-21 21:15:27 UTC
Created attachment 79259 [details] [review]
Bug 21333: Add ability to add to basket from a new file

This patch adds a workflow for adding to a basket from a file. It
removes the need to stage the file before going to the basket and allows
you to stage the file and return to the basket

To test:
1 - Have basket in acquissitions
2 - Click add to basket
3 - Note new option to 'Add from new file'
4 - Click it
5 - You will be sent to the record import tool
6 - Stage your file
7 - There is a link after staging 'Add records to basket'
8 - Click it
9 - Your items should be added

Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 10 Jonathan Druart 2018-09-21 21:15:32 UTC
Created attachment 79260 [details] [review]
Bug 21333: (follow-up) Make link a button

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 11 Jonathan Druart 2018-09-21 21:16:01 UTC
A bit hacky but works :)
Comment 12 Nick Clemens 2018-09-26 19:35:56 UTC
Awesome work all!

Pushed to master for 18.11
Comment 13 Martin Renvoize 2018-09-27 13:34:41 UTC
Enhancement, will not be backported to 18.05.x series.