Bug 21474 - Add the Koha::Subscription->frequency method
Summary: Add the Koha::Subscription->frequency method
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 21467
  Show dependency treegraph
 
Reported: 2018-10-02 15:33 UTC by Jonathan Druart
Modified: 2019-10-14 19:58 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21474: Add the Koha::Subscription->frequency method (5.27 KB, patch)
2018-10-02 15:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 21474: Add the Koha::Subscription->frequency method (5.30 KB, patch)
2018-10-02 18:07 UTC, Josef Moravec
Details | Diff | Splinter Review
xBug 21474: Add the Koha::Subscription->frequency method (5.44 KB, patch)
2018-10-17 14:45 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 21474: Add the Koha::Subscription->frequency method (5.58 KB, patch)
2018-10-28 01:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-10-02 15:33:45 UTC

    
Comment 1 Jonathan Druart 2018-10-02 15:38:58 UTC
Created attachment 79827 [details] [review]
Bug 21474: Add the Koha::Subscription->frequency method

And the 2 modules for the subscriptions' frequencies

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green
Comment 2 Josef Moravec 2018-10-02 18:07:48 UTC
Created attachment 79849 [details] [review]
Bug 21474: Add the Koha::Subscription->frequency method

And the 2 modules for the subscriptions' frequencies

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Séverine Queune 2018-10-17 14:45:07 UTC
Created attachment 80726 [details] [review]
xBug 21474: Add the Koha::Subscription->frequency method

And the 2 modules for the subscriptions' frequencies

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 4 Katrin Fischer 2018-10-28 00:58:50 UTC
 FAIL	Koha/Subscription/Frequencies.pm
   OK	  critic
   OK	  forbidden patterns
   OK	  git manipulation
   OK	  pod
   FAIL	  pod coverage
		POD is missing for 'object_class'
   OK	  spelling
   OK	  valid

Should we fix those?
Comment 5 Katrin Fischer 2018-10-28 01:00:38 UTC
Created attachment 81384 [details] [review]
Bug 21474: Add the Koha::Subscription->frequency method

And the 2 modules for the subscriptions' frequencies

Test plan:
  prove t/db_dependent/Koha/Subscription.t
must return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21475
Comment 6 Nick Clemens (kidclamp) 2018-11-07 13:10:50 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize 2018-11-16 12:49:56 UTC
Enhancement, will not be backported to 18.05.x series.