Bug 21570 - Switch two-column templates to Bootstrap grid: Various
Summary: Switch two-column templates to Bootstrap grid: Various
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks: 20654 21573
  Show dependency treegraph
 
Reported: 2018-10-15 12:46 UTC by Owen Leonard
Modified: 2019-10-14 19:56 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 21570: Update two-column templates with Bootstrap grid: Various (14.57 KB, patch)
2018-10-15 13:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21570: Update two-column templates with Bootstrap grid: Various (14.65 KB, patch)
2018-10-18 12:43 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 21570: Update two-column templates with Bootstrap grid: Various (14.73 KB, patch)
2018-10-23 15:15 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-10-15 12:46:52 UTC
These various two-column templates can be updated to use the Bootstrap grid.

 - plugins/plugins-home.tt
 - reviews/reviewswaiting.tt
 - suggestion/suggestion.tt
 - virtualshelves/shelves.tt
Comment 1 Owen Leonard 2018-10-15 13:00:09 UTC
Created attachment 80594 [details] [review]
Bug 21570: Update two-column templates with Bootstrap grid: Various

This patch modifies several assorted templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Plugins
 - Tools -> Comments
 - Acquisitions -> Suggestions
 - Lists
Comment 2 ByWater Sandboxes 2018-10-18 12:43:46 UTC
Created attachment 80822 [details] [review]
Bug 21570: Update two-column templates with Bootstrap grid: Various

This patch modifies several assorted templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Plugins
 - Tools -> Comments
 - Acquisitions -> Suggestions
 - Lists

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 3 Jonathan Druart 2018-10-23 15:15:13 UTC
Created attachment 81030 [details] [review]
Bug 21570: Update two-column templates with Bootstrap grid: Various

This patch modifies several assorted templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Administration -> Plugins
 - Tools -> Comments
 - Acquisitions -> Suggestions
 - Lists

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Nick Clemens (kidclamp) 2018-11-05 14:56:50 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-11-16 12:29:47 UTC
Enhancement, will not be backported to 18.05.x series.