SELECT * FROM message_transports; there are no phone transports Enable TalkingTechItivaPhoneNotification and EnhancedMessagingPreferences Open a patron Note you can see phone as an option, but not check it
Created attachment 81044 [details] [review] Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices
Comment on attachment 81044 [details] [review] Bug 21639: Add phone transports to new and existing installs Review of attachment 81044 [details] [review]: ----------------------------------------------------------------- ::: installer/data/mysql/en/mandatory/sample_notices_message_transports.sql @@ -4,5 @@ > (1, 'email', 0, 'circulation', 'DUE'), > (1, 'email', 1, 'circulation', 'DUEDGST'), > -(2, 'email', 0, 'circulation', 'PREDUE'), > -(2, 'email', 1, 'circulation', 'PREDUEDGST'), > -(4, 'email', 0, 'reserves', 'HOLD'), I know sorting is prettier, but a smaller patch with just phone would be easier to eyeball. :P
Created attachment 81077 [details] [review] Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
(In reply to M. Tompsett from comment #2) > I know sorting is prettier, but a smaller patch with just phone would be > easier to eyeball. :P Agreed, especially because you are going to provide the same changes for all the other languages now.
Created attachment 81085 [details] [review] Bug 21639: Adjust the other languages
installer/data/mysql/uk-UA/mandatory/sample_notices_message_transports.sql will fail
Created attachment 81169 [details] [review] Bug 21639: Add phone transports to new and existing installs To test: 1 - Confirm if you do or do not have 'phone' transports defined in the message_transports table 2 - Apply patch 3 - Run updatedatabase 4 - If you didn't have them you should now 5 - Run updatedatabase again, confirm it doesn't error 6 - sudo koha-mysql kohadev 7 - DELETE from message_transports WHERE message_transport_type = 'phone' 8 - Run updatedatabase again 9 - Confirm the message transports table is restored 10 - Drop your DB (or reset_all in kohadevbox) 11 - Ensure the table is fully populated including phone notices Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81170 [details] [review] Bug 21639: Adjust the other languages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 81171 [details] [review] Bug 21639: (follow-up) Adjust the other languages uk-UA was wrong. We should use the same file for all languages Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.06
I prefer to avoid DB changes in 17.11.x