Bug 21917 - Payment type should not show on Write off selected
Summary: Payment type should not show on Write off selected
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-29 17:31 UTC by Christopher Brannon
Modified: 2020-11-30 21:45 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2018-11-29 17:31:38 UTC
Payment type shows when you select Write off selected.  Should not be a choice.
Comment 1 Lucas Gass (lukeg) 2019-06-17 19:50:59 UTC
On the pat_paycollect page there are options to pay a fine, write off a fine, pay an individiual fine, or write off an individual fine. Clicking a button brings up the corresponding form, with the following ID's and names:

Pay selected fine: id="payfine" name="payfine"
Write off selected fine: id="payfine" name="payfine"
Pay Individual fine: id="payindivfine" name="payindivfine"
Write off individual fine: id="woindivfine" name="woindivfine"


Write off selected doesnt not have its own unique id and name. This makes it difficult to devise JavaScript that works on one but not the other.
Comment 2 Katrin Fischer 2020-04-13 02:50:58 UTC
I've tested and the payment type is on longer visible when Writeoff selected is used.