Bug 21926 - Enhance OAI-PMH:archiveID system preference description
Summary: Enhance OAI-PMH:archiveID system preference description
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Target Milestone: ---
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-30 10:26 UTC by Josef Moravec
Modified: 2018-12-07 00:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21926: Enhance OAI-PMH:archiveID system preference description (1.44 KB, patch)
2018-11-30 10:34 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21926: Enhance OAI-PMH:archiveID system preference description (1.49 KB, patch)
2018-12-05 16:04 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 21926: Enhance OAI-PMH:archiveID system preference description (1.54 KB, patch)
2018-12-05 20:52 UTC, Michal Denar
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2018-11-30 10:26:35 UTC

    
Comment 1 Josef Moravec 2018-11-30 10:34:33 UTC
Created attachment 82774 [details] [review]
Bug 21926: Enhance OAI-PMH:archiveID system preference description

Test plan:
1) Apply the patch
2) Go to Administration -> System preferences -> Web services, section
OAI-PMH
3) See description on OAI-PMH:archiveID and confirm it does make sense
and have the link to implementation guidelines
Comment 2 Owen Leonard 2018-12-05 15:14:05 UTC
+            - ": . The archiveID should respect OAI specification. See "

I think the ": " needs to be removed here while you're making changes. I don't see why it's there.
Comment 3 Josef Moravec 2018-12-05 16:03:44 UTC
(In reply to Owen Leonard from comment #2)
> +            - ": . The archiveID should respect OAI specification. See "
> 
> I think the ": " needs to be removed here while you're making changes. I
> don't see why it's there.

As I understand it, the colon is here to show that it is not needed to insert it into the form field...

But it could be improved. I'll try something...
Comment 4 Josef Moravec 2018-12-05 16:04:08 UTC
Created attachment 82875 [details] [review]
Bug 21926: Enhance OAI-PMH:archiveID system preference description

Test plan:
1) Apply the patch
2) Go to Administration -> System preferences -> Web services, section
OAI-PMH
3) See description on OAI-PMH:archiveID and confirm it does make sense
and have the link to implementation guidelines
Comment 5 Michal Denar 2018-12-05 20:52:07 UTC
Created attachment 82892 [details] [review]
Bug 21926: Enhance OAI-PMH:archiveID system preference description

Test plan:
1) Apply the patch
2) Go to Administration -> System preferences -> Web services, section
OAI-PMH
3) See description on OAI-PMH:archiveID and confirm it does make sense
and have the link to implementation guidelines

Signed-off-by: Michal Denar <black23@gmail.com>