Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior.
Created attachment 83308 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 83309 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 83346 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org>
Created attachment 85146 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
@RM: Would have been even more convincing with a small test in say t/db/SIP/Message.t
Created attachment 85289 [details] [review] Bug 22014: Unit tests
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series