As far as I can tell, the "test/search.pl" script isn't used for anything and can be removed.
sorry for the noise, mistake
Created attachment 88040 [details] [review] Bug 22056: Removed test/search.pl test/search.pl is old, and does not appear to be used anywhere. This patch removes this file. Test plan: Verify that test/search.pl has been removed. Sponsored-by: Catalyst IT.
Created attachment 88368 [details] [review] Bug 22056: Removed test/search.pl test/search.pl is old, and does not appear to be used anywhere. This patch removes this file. Test plan: Verify that test/search.pl has been removed. Sponsored-by: Catalyst IT. Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Hi Hayley, I think if we decide to remvoe the script, we should also remove the directory test and the README file. What do you think?
Adding Jonathan and Tomas as I can see them in the history for these files.
Added by bug 5309. See also: commit f8a58d310ee96a4bf272c9ae16dc347bf1d0e4ea Author: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Date: Mon Aug 17 13:54:44 2015 +0200 Bug 14321: Final cleanup, removing obsolete files The new Upload.pm, unit test and file-upload.js obsolete a number of files, including an older jQuery plugin. The test files progressbar.pl and progressbarsubmit.pl are outdated and do not serve any purpose in this form. (Actually, we could argue if they should be here or just be part of a debugging phase.) I am fine with removing -r search/
Created attachment 88841 [details] [review] Bug 22056: Removed test directory, including search.pl and README Test plan: Check that this directory has been removed. Sponsored-by: Catalyst IT
Created attachment 88844 [details] [review] Bug 22056: Removed test directory, including search.pl and README Test plan: Check that this directory has been removed. Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Going straight to PQA here, thx Hayley!
Awesome work all! Pushed to master for 19.05
Prefer not to tidy out during stable cycle.