Bug 22101 - ILL requests missing in menu on advanced search page
Summary: ILL requests missing in menu on advanced search page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-11 15:01 UTC by Martin Renvoize
Modified: 2020-01-06 20:14 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 22101: Ill Requests missing in menu on advanced search page (1.11 KB, patch)
2019-01-11 16:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 22101: Ill Requests missing in menu on advanced search page (1.16 KB, patch)
2019-01-11 19:00 UTC, Maryse Simard
Details | Diff | Splinter Review
Bug 22101: Ill Requests missing in menu on advanced search page (1.23 KB, patch)
2019-01-13 17:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-01-11 15:01:16 UTC
A picture speaks a thousand words.

On the 'advanced search' page on the staff client.. the 'Ill requests' option is missing from the 'More' dropdown menu in the header menu bar.
Comment 1 Owen Leonard 2019-01-11 16:34:38 UTC
Created attachment 83811 [details] [review]
Bug 22101: Ill Requests missing in menu on advanced search page

This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.

To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.

- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
  "ILL requests."
Comment 2 Maryse Simard 2019-01-11 19:00:35 UTC
Created attachment 83821 [details] [review]
Bug 22101: Ill Requests missing in menu on advanced search page

This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.

To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.

- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
  "ILL requests."

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Comment 3 Katrin Fischer 2019-01-13 17:36:31 UTC
Created attachment 83843 [details] [review]
Bug 22101: Ill Requests missing in menu on advanced search page

This patch adds [% USE Koha %] to header.inc so that Koha.Preference
calls will work correctly.

To test, apply the patch and log in to the staff client as a user who
has permission to access the ILL module.

- Go to the catalog's advanced search page
- Cnfirm there is a header menu item under "More" for
  "ILL requests."

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Nick Clemens (kidclamp) 2019-01-18 21:00:06 UTC
Awesome work all!

Pushed to master for 19.05
Comment 5 Martin Renvoize 2019-01-31 16:16:23 UTC
Pushed to 18.11.x for 18.11.03
Comment 6 Lucas Gass 2019-02-01 18:34:18 UTC
pushed to 18.05.x for 18.05.09
Comment 7 Fridolin Somers 2019-02-04 09:38:03 UTC
Pushed to 17.11.x for 17.11.15