Our coding guidelines make it mandatory to flag boolean columns as such (and use the TINYINT type on their definitions. QA on bug 7534 missed this.
Created attachment 83883 [details] [review] Bug 22125: branches.pickup_location should be flagged as boolean This trivial patch just marks the mentioned column as a boolean. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 83944 [details] [review] Bug 22125: branches.pickup_location should be flagged as boolean This trivial patch just marks the mentioned column as a boolean. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 84206 [details] [review] Bug 22125: branches.pickup_location should be flagged as boolean This trivial patch just marks the mentioned column as a boolean. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=16497 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
MY mistake. this should NOT be 18.05 as it is missing dependencies. Reverted commit.