Bug 22352 - Items location not shown correctly in email sent lists
Summary: Items location not shown correctly in email sent lists
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Didier Gautheron
QA Contact: Testopia
URL:
Keywords:
Depends on: 26323
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-15 17:04 UTC by Alexandre
Modified: 2021-07-09 18:44 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
no home library (121.51 KB, image/jpeg)
2019-02-15 17:04 UTC, Alexandre
Details
authorized value (110.73 KB, image/png)
2020-03-11 18:23 UTC, Marjorie Barry-Vila
Details
Bug 22352: lists sent by mail, print location description (1.75 KB, patch)
2020-07-29 09:35 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 22352: lists sent by mail, print location description (1.75 KB, patch)
2020-07-29 09:37 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 22352: lists sent by mail, print location description (1.80 KB, patch)
2020-10-26 14:26 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 22352: lists sent by mail, print location description (2.93 KB, patch)
2020-11-05 13:37 UTC, Didier Gautheron
Details | Diff | Splinter Review
Bug 22352: lists sent by mail, print location description (3.05 KB, patch)
2021-04-19 17:51 UTC, Didier Gautheron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre 2019-02-15 17:04:34 UTC
Created attachment 85183 [details]
no home library

The lists sent by mail doesn’t show correctly the home library of items. The mail shows the current location and that’s all. Rather than this, the mail shows an authorized value. The home library isn’t shown which is useful for the students to guide them where the books are.

1)	Go to lists
2)	Choose a list and send it at one of your emails and close the window
3)	In the sent mail, watch the infos below the “Item” mention, they are wrong (see picture underlined in red)

note that the home library isn't following the current location of the book. We have the authorized value of the item shown there. 

Best regards,

Alexandre
Comment 1 Marjorie Barry-Vila 2019-12-20 16:26:08 UTC
+1
Comment 2 Katrin Fischer 2019-12-22 10:06:18 UTC
Alexandre, if the problem is that the shown location might belong to the home library instead of the current library than I am not sure how we can solve this.

There is no way to tell if the location applies to the current or the home library.

Examples that come to mind:
It could also be "CART" or "PROC" which are correct independent from the library setting. Or it might be part of course reserves and the current library has set the location to a specific "course reserves" location.

What solution would you prefer?
Comment 3 Marjorie Barry-Vila 2020-03-11 18:23:18 UTC
(In reply to Katrin Fischer from comment #2)
> Alexandre, if the problem is that the shown location might belong to the
> home library instead of the current library than I am not sure how we can
> solve this.
> 
> There is no way to tell if the location applies to the current or the home
> library.
> 
> Examples that come to mind:
> It could also be "CART" or "PROC" which are correct independent from the
> library setting. Or it might be part of course reserves and the current
> library has set the location to a specific "course reserves" location.
> 
> What solution would you prefer?

Hi Katrin,

Alexandre no longer works for our company now.

What he wanted to mention in this ticket is that the location of an item in the mail was displayed under the code of the authorized value and not by its opac description.

Example of the screenshot "no_home_library"
*Campus de Québec  LIMOI.QUEBEC.CAV (DVD C154)

should rather be written
*Campus de Québec Comptoir du prêt (Enregistrements vidéo) (DVD C154)

Is it clearer for you?

Regards,
Marjorie
Comment 4 Marjorie Barry-Vila 2020-03-11 18:23:56 UTC
Created attachment 100597 [details]
authorized value
Comment 5 Didier Gautheron 2020-07-29 09:35:19 UTC
Created attachment 107478 [details] [review]
Bug 22352: lists sent by mail, print location description

For patrons location codes aren't very useful, replace them with their
descriptions as defined in authorised values.

1)	Go to lists
2)	Choose a list and send it at one of your emails
3)	In the sent mail, watch the infos below the “Item” mention, location
    codes are displayed
4)  Apply patch
5)  Redo 1) and 2)
6)  Location descriptions are displayed
Comment 6 Didier Gautheron 2020-07-29 09:37:36 UTC
Created attachment 107479 [details] [review]
Bug 22352: lists sent by mail, print location description

For patrons location codes aren't very useful, replace them with their
descriptions as defined in authorised values.

1)  Go to lists
2)  Choose a list and send it at one of your emails
3)  In the sent mail, watch the infos below the “Item” mention, location
    codes are displayed
4)  Apply patch
5)  Redo 1) and 2)
6)  Location descriptions are displayed
Comment 7 Séverine Queune 2020-10-26 14:26:20 UTC
Created attachment 112520 [details] [review]
Bug 22352: lists sent by mail, print location description

For patrons location codes aren't very useful, replace them with their
descriptions as defined in authorised values.

1)  Go to lists
2)  Choose a list and send it at one of your emails
3)  In the sent mail, watch the infos below the “Item” mention, location
    codes are displayed
4)  Apply patch
5)  Redo 1) and 2)
6)  Location descriptions are displayed

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 8 Séverine Queune 2020-10-26 14:30:23 UTC
Useful one, thanks Didier !
Comment 9 Séverine Queune 2020-10-26 15:11:20 UTC
I just realize I tested only from opac side, and the problem is not fixed sending a list from staff interface.
Does this patch suppose to modify only the OPAC issue ?
Comment 10 Didier Gautheron 2020-10-26 15:18:59 UTC
Hi,

No, good catch it should do the same from staff.

I'm adding it later this evening.

Regards
Didier
Comment 11 Didier Gautheron 2020-11-05 13:37:41 UTC
Created attachment 113112 [details] [review]
Bug 22352: lists sent by mail, print location description

For patrons location codes aren't very useful, replace them with their
descriptions as defined in authorised values.

For staff add descriptions.

1)  Go to lists in Opac interface
2)  Choose a list and send it at one of your emails
3)  In the sent mail, watch the infos below the “Item” mention, location
    codes are displayed
4)  Apply patch
5)  Redo 1) and 2)
6)  Location descriptions are displayed
7)  Do the same with staff interface
Comment 12 Fridolin Somers 2021-01-12 15:19:09 UTC
We avoid using directly AV category 'LOC', please see Bug 26323
Comment 13 Didier Gautheron 2021-04-19 17:51:06 UTC
Created attachment 119868 [details] [review]
Bug 22352: lists sent by mail, print location description

For patrons location codes aren't very useful, replace them with their
descriptions as defined in authorised values.

For staff add descriptions.

1)  Go to lists in Opac interface
2)  Choose a list and send it at one of your emails
3)  In the sent mail, watch the infos below the “Item” mention, location
    codes are displayed
4)  Apply patch
5)  Redo 1) and 2)
6)  Location descriptions are displayed
7)  Do the same with staff interface
Comment 14 Kelly McElligott 2021-07-09 18:44:58 UTC
Hi, Do you have a good way of testing this without having to set up email generation on a test server?