Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page.
*** Bug 20574 has been marked as a duplicate of this bug. ***
Created attachment 86841 [details] [review] Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display!
Created attachment 86850 [details] [review] Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display! Signed-off-by: Liz Rea <wizzyrea@gmail.com>
If a sub-fund assigned to a specific library is collapsed, it is not shown in the results when the table is filtered. I can understand if this is an acceptable behavior, but personally I expected all related funds to be shown when filtering by library. In a similar fashion, if a "main" fund is assigned to a library but its sub-funds are not, the main fund has the collapse/expand arrow even though there is nothing else to show. (I'm not sure how often that would happen in real production servers though)
Created attachment 86929 [details] [review] Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display! Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
It is ok to follow the test plan, I saw José-Mario's comment and added sub-fund to main fund. It is true that sub-fund is not shown after filtering, which is indeed a problem in my opinion.
Created attachment 87567 [details] [review] Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display! Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.