There were multiple error messages in the staff client that had slightly awkward text, for example: "This patron does not exist" should be "Patron not found." "This $thing does not exist" should be "$thing not found." "Find another $thing?" should be "Return to search." "You are not allowed to see the information of this patron" should be "This account cannot view requested patron information" - this change makes it less personal, and might remind a person to check another account or to ask a supervisor if access is really required. I say this because it's not always the *person* who can't see a patron record, but the account that is currently logged in.
Created attachment 87286 [details] [review] Bug 22616: Updating error text messages To test: Apply this patch Go to a borrower that doesn't exist, check that the error message is displayed and looks correct. (i.e. http://127.0.0.1:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=9999999999999999) Go to an item, subscription, biblio that don't exist, check that the error message is correct and the links work Go to a borrower that the logged in user doesn't have permission to see, check that the error message is correct and the links work.
Created attachment 87459 [details] [review] Bug 22616: Updating error text messages To test: Apply this patch Go to a borrower that doesn't exist, check that the error message is displayed and looks correct. (i.e. http://127.0.0.1:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=9999999999999999) Go to an item, subscription, biblio that don't exist, check that the error message is correct and the links work Go to a borrower that the logged in user doesn't have permission to see, check that the error message is correct and the links work. Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Bin, please don't forget to set the status to 'Signed off' when you are happy with the patch after testing.
Created attachment 87553 [details] [review] Bug 22616: Updating error text messages To test: Apply this patch Go to a borrower that doesn't exist, check that the error message is displayed and looks correct. (i.e. http://127.0.0.1:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=9999999999999999) Go to an item, subscription, biblio that don't exist, check that the error message is correct and the links work Go to a borrower that the logged in user doesn't have permission to see, check that the error message is correct and the links work. Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.