Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record.
Created attachment 87371 [details] [review] Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl
Created attachment 87408 [details] [review] Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 87453 [details] [review] Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 87506 [details] [review] Bug 22631: Make links on barcode on hold summary page consistent (bug 21070) Bug 21070 changed the link on the holds summary so the barcode would link to the item on moredetail for an item level hold. If a hold is already waiting, the link still goes to the detail page of the record. This patch changes it so the barcode always links to the item. To test: - Place some item level holds on a record - Verify the barcodes on the hold summary page link to moredetail.pl - Return one of the items so that the hold is waiting - Verify the barcode links to the record detail page now - Apply patch - Verify barcodes for pending and waiting holds now both link to moredetail.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice fix, no regressions.. PQA
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.