Created attachment 87488 [details] [review] Bug 22656: Fix charts in reports This reverts a change on Create chart button in report toolbar made by bug 22023 1) Confirm the bug a) Create some SQL report b) Run it and click on "Show chart settings" button c) There is no modal or other way to actually draw the chart 2) Apply the patch 3) Go through 1) again - the modal and chart should work Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 87522 [details] [review] Bug 22656: Fix charts in reports This reverts a change on Create chart button in report toolbar made by bug 22023 1) Confirm the bug a) Create some SQL report b) Run it and click on "Show chart settings" button c) There is no modal or other way to actually draw the chart 2) Apply the patch 3) Go through 1) again - the modal and chart should work Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 87559 [details] [review] Bug 22656: Fix charts in reports This reverts a change on Create chart button in report toolbar made by bug 22023 1) Confirm the bug a) Create some SQL report b) Run it and click on "Show chart settings" button c) There is no modal or other way to actually draw the chart 2) Apply the patch 3) Go through 1) again - the modal and chart should work Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Bug with enhancement not in 18.11.x series.