If you regenerate the schema on stretch you get a change to SocialData
I haven't committed it because I didn't kow where it came from, I don't believe it will affect anything, but wanted to document the change at the least
On debian 9 run misc/devel/update_dbix_class_files.pl
(devbox or koha testing docker just do dbic)
Note the change
Verify all works with this change
*** Bug 22096 has been marked as a duplicate of this bug. ***
My bet would be a change in DBIx::Class::Schema::Loader, however I did not find it.
social_data.isbn is a varchar and used as PK, so cannot be NULL, I guess that's why it has a default ''.
Also note that "show create table" will display the NOT NULL constraint:
`isbn` varchar(30) COLLATE utf8mb4_unicode_ci NOT NULL,
It looks safe to commit, and better to fix the kohastructure.sql as well.
Created attachment 89539 [details] [review]
Bug 22782: DBIC update for SocialData
Trivial, just leaving here for reference
Awesome work all!
Pushed to master for 19.05
Pushed to 18.11.x for 18.11.06