Bug 22956 - Omnibus: Remove type attribute from script tags
Summary: Omnibus: Remove type attribute from script tags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 16785 22957 22973 22975 22979 22981 23226 23227 27531 27561 28331
Blocks:
  Show dependency treegraph
 
Reported: 2019-05-21 18:20 UTC by Owen Leonard
Modified: 2022-06-06 20:25 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-05-21 18:20:56 UTC
Bug 20053 removed all "type" attributes from <script> tags in OPAC templates.* We should do the same for the staff client templates.

* A couple of regressions have made it in which need to be fixed.

This bug will act as an omnibus bug for collecting bugs of smaller scope.
Comment 1 Aleisha Amohia 2021-01-20 02:44:16 UTC
Hello, what is the status of this bug?
Comment 2 Owen Leonard 2021-01-20 16:38:49 UTC
(In reply to Aleisha Amohia from comment #1)
> Hello, what is the status of this bug?

There are still many instances left in the templates where I see <script type="text/javascript"> instead of simply <script>, so more bugs could be filed and made to block this one.

about.tt:
auth.tt:
intranet-main.tt:
circ/overdue.tt:
clubs/patron-clubs-tab.tt:
clubs/patron-enroll.tt:
common/patron_search.tt:
course_reserves/course.tt:
members/members-update.tt:
members/update-child.tt:
offline_circ/process_koc.tt:
serials/acqui-search-result.tt:
serials/result.tt:
serials/routing-preview-slip.tt:
serials/subscription-renew.tt:
tools/batchMod-del.tt:
tools/batchMod-edit.tt:
tools/inventory.tt:

...and all the cataloging plugins.
Comment 3 Owen Leonard 2021-05-12 13:59:09 UTC
(In reply to Owen Leonard from comment #2)

> circ/overdue.tt:

One left. Bug 28331.
Comment 4 Katrin Fischer 2021-06-03 22:40:52 UTC
Looks like we are done here? :)