We should be allowed to change the homebranch when adding items in course reserves with the "batch add reserves" button.
Created attachment 90059 [details] [review] Bug 22970: Allow to change homebranch in batch add course reserves Test plan: 1. Create a course (disabled) 2. Add multiple reserves to this course using 'batch add' and set a homebranch different from the items homebranch 3. Enable the course 4. Verify that the items homebranch have changed 5. Disable the course 6. Verify that the items homebranch were reset to their initial value Depends on bug 22630
Created attachment 90062 [details] [review] Bug 22970: Allow to change homebranch in batch add course reserves Test plan: 1. Create a course (disabled) 2. Add multiple reserves to this course using 'batch add' and set a homebranch different from the items homebranch 3. Enable the course 4. Verify that the items homebranch have changed 5. Disable the course 6. Verify that the items homebranch were reset to their initial value Depends on bug 22630 Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Currently blocked by failed dependency patch.
I applied it on top of BZ 22630 on a sandbox. I tested it according to the plan test and everything was fine. I also tried to modify the value changed by the reserve course, to delete one item in the course and to delete a course. Everything works fine, the value of the item return to their original values. I'm changing the status to "signed off" but I can't modify the patch with the sandbox as there was several bugs applied. Sonia
Created attachment 104163 [details] [review] Bug 22970: Allow to change homebranch in batch add course reserves Test plan: 1. Create a course (disabled) 2. Add multiple reserves to this course using 'batch add' and set a homebranch different from the items homebranch 3. Enable the course 4. Verify that the items homebranch have changed 5. Disable the course 6. Verify that the items homebranch were reset to their initial value Depends on bug 22630 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I think it would be really nice to have this one in still - it complements bug 22630 already pushed and makes it feature complete. Changes are quite small, but I had to do a bit heavier rebase, so leaving it with my sign-off for now.
Created attachment 104485 [details] [review] Bug 22970: Allow to change homebranch in batch add course reserves Test plan: 1. Create a course (disabled) 2. Add multiple reserves to this course using 'batch add' and set a homebranch different from the items homebranch 3. Enable the course 4. Verify that the items homebranch have changed 5. Disable the course 6. Verify that the items homebranch were reset to their initial value Depends on bug 22630 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11
Should we add sponsorship here as well? (noticed the line on bug 22630)
Hi, Yes this one was also sponsored By Université de Lyon 3. Sonia