Bug 21946 (accidentally) removed inclusion of str/members-menu.inc, breaking JavaScript validation of the two password fields on the "change password" page.
Created attachment 90030 [details] [review] Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above."
Created attachment 90043 [details] [review] Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 90080 [details] [review] Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Created attachment 90099 [details] [review] Bug 22974: Patron password update validation broken This patch adds back an include file to the change password template which was inadvertently removed by Bug 21964. This broke Javascript validation of the new password fields. To test, apply the patch and enable the RequireStrongPassword system preference. - Go to Patrons -> Patron details -> Change password. - Try entering a weak password in the "New password" field. You should get a validation error: "Password must contain at least 3 characters, including UPPERCASE, lowercase and numbers." - Try entering a password in the second password field which doesn't match the first. You should get a validation error: "Please enter the same password as above." Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Awesome work all! Pushed to master for 19.05
Bug with enhancement not in 18.11.x series.