Bug 23167 - We should factor out shared code from Auth_with_cas.pm and Auth_with_shibboleth.pm
Summary: We should factor out shared code from Auth_with_cas.pm and Auth_with_shibbole...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-20 07:29 UTC by Martin Renvoize (ashimema)
Modified: 2019-06-20 07:29 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2019-06-20 07:29:33 UTC 
These two authentication mechanisms are starting to duplicate each others code in places; for example building a return url is now present in a nearly matching routine for both.

We should factor out the similar routines into their own module.