Bug 23241 - Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha?
Summary: Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha?
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords: release-notes-needed
Depends on: 8519
Blocks:
  Show dependency treegraph
 
Reported: 2019-07-01 09:45 UTC by Martin Renvoize
Modified: 2023-10-12 20:48 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This script was never fully promoted or documented. It also required third party libraries to be installed. If you have been using this, please consider switching to the standard koha-indexer scripts.
Version(s) released in:
23.11.00


Attachments
Bug 23241: Remove unused koha-index-daemon-ctl.sh (3.76 KB, patch)
2023-10-09 10:45 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 23241: Remove unused koha-index-daemon-ctl.sh (3.81 KB, patch)
2023-10-09 19:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2019-07-01 09:45:18 UTC
We have had a daemon mode in rebuild_zebra.pl for a long time and have been using that as the default indexing daemon for years.. Should we deprecate the above script to prevent confusion for new users where indexing should just work out of the box without the need for installing external dependancies.
Comment 1 Katrin Fischer 2023-10-08 11:29:22 UTC
What's the status here? I get that the file does not related to the koha-indexer?
Comment 2 Martin Renvoize 2023-10-09 10:42:52 UTC
I believe it's still the case.. we only mention the script in the Makefile and don't actively use or encourage it anywhere.. I'm not sure it was ever documented either.

I vote to remove it still.
Comment 3 Martin Renvoize 2023-10-09 10:45:37 UTC
Created attachment 156730 [details] [review]
Bug 23241: Remove unused koha-index-daemon-ctl.sh

This script was never fully promoted or documented and it requires third
party libraries are installed to use. This patch removes it from the
repository and the Makefile so it is no longer installed.
Comment 4 Katrin Fischer 2023-10-09 19:23:01 UTC
Created attachment 156759 [details] [review]
Bug 23241: Remove unused koha-index-daemon-ctl.sh

This script was never fully promoted or documented and it requires third
party libraries are installed to use. This patch removes it from the
repository and the Makefile so it is no longer installed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-10-09 19:24:15 UTC
Moving to PQA.
Comment 6 Tomás Cohen Arazi 2023-10-10 12:23:00 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Katrin Fischer 2023-10-10 13:51:28 UTC
I tried my hand at the release notes - please check!
Comment 8 Fridolin Somers 2023-10-12 20:48:02 UTC
I prefer not to push to 23.05.x