In Koha version in 18.11, HTML tags should be allowed in Hold Notes. THis is similar to bug 23194, 22702, 22501.
Created attachment 91609 [details] [review] Bug 23341: Hold Notes should allow for HTML tags TEST PLAN: 1. place a hold 2. make sure you add a note that includes HTML like "<a href="www.google.com">yolo</a>" 3. notice that HTML displays literally 4. apply patch 5. Now the note field should render the HTML
Created attachment 91658 [details] [review] Bug 23341: Hold Notes should allow for HTML tags Signed-off-by: Jessica Ofsa <jofsa@vt.edu>
HTML tested: TN 149xxxx <br> Title: <br> Call Number: BF721 .P8 V. 58 <br> Year: 20030101 <br> V. 58 <br> Issue/Part: <br> pg. 35- <br> Article Title: Margo and me. Gender as a cause and solution to unmet needs. <br> Article Author: Knight, Rona, <br> Resulting hold note: TN 149xxxx Title: Call Number: BF721 .P8 V. 58 Year: 20030101 V. 58 Issue/Part: pg. 35- Article Title: Margo and me. Gender as a cause and solution to unmet needs. Article Author: Knight, Rona,
Created attachment 91661 [details] [review] Bug 23341: Hold Notes should allow for HTML tags Signed-off-by: Jessica Ofsa <jofsa@vt.edu> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com>
This has one caveat - patrons can enter these notes, not just staff, so this would open possibility of XSS attack Talking internally we think we could filter the patron note on entry Alternatively, we can split the note into a public_note and private_note - filter the public and display it to patrons, but don't filter the private_note and keep it only for staff
(In reply to Nick Clemens from comment #5) > This has one caveat - patrons can enter these notes, not just staff, so this > would open possibility of XSS attack > > Talking internally we think we could filter the patron note on entry > > Alternatively, we can split the note into a public_note and private_note - > filter the public and display it to patrons, but don't filter the > private_note and keep it only for staff Do we know more about the use case for this? If it's about handling line breaks like in the example from Jessica we could handle this easily without allowing line breaks. Otherwise I really like the idea of splitting into internal and public notes as this would allow for more flexible use. Right now if you use the note publicly, you don't have any way to make internal notes and this could easily go wrong. Should we reset status here to "In discussion"?
Moving this to discussion for now.
see bz 25468 for new approach to solving the problem