Bug 23599 - Koha::Objects::Limit::Library fails if no library passed
Summary: Koha::Objects::Limit::Library fails if no library passed
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 23281
Blocks: 15497
  Show dependency treegraph
 
Reported: 2019-09-12 14:37 UTC by Tomás Cohen Arazi
Modified: 2019-09-13 12:54 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.11.00


Attachments
Bug 23599: Regression tests (1.53 KB, patch)
2019-09-12 14:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed (960 bytes, patch)
2019-09-12 14:39 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 23599: Regression tests (1.59 KB, patch)
2019-09-12 14:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed (1.00 KB, patch)
2019-09-12 14:59 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2019-09-12 14:37:04 UTC
The search_with_library_limits method is not tested, and when used in 15497 it proved to explode when no library is passed.
Comment 1 Tomás Cohen Arazi 2019-09-12 14:39:26 UTC
Created attachment 92730 [details] [review]
Bug 23599: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2019-09-12 14:39:30 UTC
Created attachment 92731 [details] [review]
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Martin Renvoize 2019-09-12 14:58:59 UTC
Created attachment 92733 [details] [review]
Bug 23599: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-09-12 14:59:04 UTC
Created attachment 92734 [details] [review]
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-09-12 15:00:11 UTC
Straight to QA.. works well, fixes the issue.
Comment 6 Martin Renvoize 2019-09-12 15:01:00 UTC
Nice work!

Pushed to master for 19.11.00
Comment 7 Fridolin SOMERS 2019-09-13 12:54:36 UTC
Depends on Bug 23281 not in 19.05.x