Bug 23599 - Koha::Objects::Limit::Library fails if no library passed
Summary: Koha::Objects::Limit::Library fails if no library passed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 23281
Blocks: 15497
  Show dependency tree / graph
 
Reported: 2019-09-12 14:37 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2020-06-04 20:32 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Circulation function:

Attachments
Bug 23599: Regression tests (1.53 KB, patch)
2019-09-12 14:39 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed (960 bytes, patch)
2019-09-12 14:39 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 23599: Regression tests (1.59 KB, patch)
2019-09-12 14:58 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed (1.00 KB, patch)
2019-09-12 14:59 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2019-09-12 14:37:04 UTC 
The search_with_library_limits method is not tested, and when used in 15497 it proved to explode when no library is passed.
Comment 1 Tomás Cohen Arazi (tcohen) 2019-09-12 14:39:26 UTC 
Created attachment 92730 [details] [review]
Bug 23599: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi (tcohen) 2019-09-12 14:39:30 UTC 
Created attachment 92731 [details] [review]
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Martin Renvoize (ashimema) 2019-09-12 14:58:59 UTC 
Created attachment 92733 [details] [review]
Bug 23599: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2019-09-12 14:59:04 UTC 
Created attachment 92734 [details] [review]
Bug 23599: Avoid exploding in search_with_library_limits when no library is passed

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2019-09-12 15:00:11 UTC 
Straight to QA.. works well, fixes the issue.
Comment 6 Martin Renvoize (ashimema) 2019-09-12 15:01:00 UTC 
Nice work!

Pushed to master for 19.11.00
Comment 7 Fridolin Somers 2019-09-13 12:54:36 UTC 
Depends on Bug 23281 not in 19.05.x