Bug 23702 - New UNIMARC XSLT according to last IFLA updates
Summary: New UNIMARC XSLT according to last IFLA updates
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: delaye
QA Contact: Testopia
URL:
Keywords:
Depends on: 20424
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-30 14:34 UTC by delaye
Modified: 2022-05-03 12:14 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
xslt unimarc intranet detail (112.66 KB, application/xslt+xml)
2019-09-30 14:34 UTC, delaye
Details
xslt intranet result (13.79 KB, application/xslt+xml)
2019-09-30 14:35 UTC, delaye
Details
xslt intranet utils (53.89 KB, application/xslt+xml)
2019-09-30 14:35 UTC, delaye
Details
xslt opac detail (107.09 KB, application/xslt+xml)
2019-09-30 14:36 UTC, delaye
Details
xslt opac result (17.88 KB, application/xslt+xml)
2019-09-30 14:36 UTC, delaye
Details
xslt opac utils (65.13 KB, application/xslt+xml)
2019-09-30 14:37 UTC, delaye
Details
index file 1 (65.40 KB, text/xml)
2019-09-30 15:14 UTC, delaye
Details
index file 2 (48.88 KB, text/plain)
2019-09-30 15:14 UTC, delaye
Details
index file 3 (11.24 KB, text/plain)
2019-09-30 15:15 UTC, delaye
Details
UNIMARCslim2intranetDetail.xsl (98.82 KB, text/xml)
2019-10-08 13:46 UTC, Koha Team University Lyon 3
Details
UNIMARCslim2intranetResults.xsl (10.10 KB, text/xml)
2019-10-08 13:47 UTC, Koha Team University Lyon 3
Details
UNIMARCslim2OPACDetail.xsl (94.45 KB, text/xml)
2019-10-08 13:47 UTC, Koha Team University Lyon 3
Details
UNIMARCslim2OPACResults.xsl (17.02 KB, text/xml)
2019-10-08 13:48 UTC, Koha Team University Lyon 3
Details
OPAC UNIMARCslimUtils.xsl (50.89 KB, text/xml)
2019-10-08 13:53 UTC, Koha Team University Lyon 3
Details
Opac detail (97.78 KB, application/xslt+xml)
2019-10-17 12:31 UTC, delaye
Details
intranet detail xslt (103.38 KB, application/xslt+xml)
2019-10-17 12:32 UTC, delaye
Details
Bug 23702 - New UNIMARC XSLT according to last IFLA updates (435.21 KB, patch)
2019-11-19 16:43 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Intranet xslt result new version (9.93 KB, text/plain)
2019-12-03 15:41 UTC, delaye
Details
OPAX -xslt utils (52.83 KB, application/xslt+xml)
2020-01-20 14:30 UTC, delaye
Details
Bug 23702 - New UNIMARC XSLT according to last IFLA updates (437.27 KB, text/plain)
2020-01-23 16:57 UTC, Koha Team University Lyon 3
Details
xslt opac (11.22 KB, text/plain)
2020-03-23 10:50 UTC, delaye
Details
xslt intranet (10.26 KB, text/plain)
2020-03-23 10:51 UTC, delaye
Details
Bug 23702 - New UNIMARC XSLT according to last IFLA updates (385.47 KB, patch)
2020-04-21 13:47 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description delaye 2019-09-30 14:34:00 UTC
Created attachment 93308 [details]
xslt unimarc intranet detail

In attachments the new xslt files UNIMARC and  zebra configuration files.
The xslt file call new index about the link fields(4xx).

The news:
-add fields for the bibliographic transition(181,182,183,214)
-add fields 923 and 924 for display better the summaries of collection
-display better the punctuation isbd
-fields 600 à 608 : search the string with phr and not with number authority
..etc

Test plan

1.Install the intranet xslt files into : ~/src/koha-tmpl/intranet-tmpl/prog/en/xslt

2.Install the opac xslt files into : 
:~/src/koha-tmpl/opac-tmpl/bootstrap/en/xslt

3.Install the file 'biblio-koha-indexdefs.xml' into /home/koha/etc/zebradb/marc_defs/unimarc/biblios/

4.Install the file 'ccl.properties' into /home/koha/etc/zebradb/

5.Install the file 'bib1.att' into/home/koha/etc/zebradb/biblios/etc/

6.Run the indexation
cd /home/koha/tools/zebra;update_xsl_config.sh -a -b;./rebuild_full.sh -b -a;
Comment 1 delaye 2019-09-30 14:35:03 UTC
Created attachment 93318 [details]
xslt intranet result
Comment 2 delaye 2019-09-30 14:35:38 UTC
Created attachment 93319 [details]
xslt intranet utils
Comment 3 delaye 2019-09-30 14:36:14 UTC
Created attachment 93320 [details]
xslt opac detail
Comment 4 delaye 2019-09-30 14:36:41 UTC
Created attachment 93321 [details]
xslt opac result
Comment 5 delaye 2019-09-30 14:37:14 UTC
Created attachment 93322 [details]
xslt opac utils
Comment 6 delaye 2019-09-30 15:14:20 UTC
Created attachment 93331 [details]
index file 1
Comment 7 delaye 2019-09-30 15:14:38 UTC
Created attachment 93332 [details]
index file 2
Comment 8 delaye 2019-09-30 15:15:00 UTC
Created attachment 93333 [details]
index file 3
Comment 9 Koha Team University Lyon 3 2019-10-08 13:46:53 UTC
Created attachment 93866 [details]
UNIMARCslim2intranetDetail.xsl
Comment 10 Koha Team University Lyon 3 2019-10-08 13:47:25 UTC
Created attachment 93867 [details]
UNIMARCslim2intranetResults.xsl
Comment 11 Koha Team University Lyon 3 2019-10-08 13:47:59 UTC
Created attachment 93868 [details]
UNIMARCslim2OPACDetail.xsl
Comment 12 Koha Team University Lyon 3 2019-10-08 13:48:40 UTC
Created attachment 93869 [details]
UNIMARCslim2OPACResults.xsl
Comment 13 Koha Team University Lyon 3 2019-10-08 13:53:55 UTC
Created attachment 93870 [details]
OPAC UNIMARCslimUtils.xsl
Comment 14 Koha Team University Lyon 3 2019-10-08 14:02:49 UTC
After discussion with other french librarians, we thought that it could be useful to add to the last attachements the followings fields :

for the OPAC : 506, 507, 576, 577, 623, 703, 713 et 723 

For the intranet : 181, 182, 183, in addition of the fields above


Thanks,
Sonia
Comment 15 delaye 2019-10-17 12:31:14 UTC
Created attachment 94369 [details]
Opac detail

OPAC detail :add the field 506, 507, 576, 577, 623, 703, 713 et 723
Comment 16 delaye 2019-10-17 12:32:48 UTC
Created attachment 94370 [details]
intranet detail xslt

intranet detail : add the fields 181,182,183, 506, 507, 576, 577, 623, 703, 713 et 723
Comment 17 Koha Team University Lyon 3 2019-11-19 16:43:55 UTC
Created attachment 95581 [details] [review]
Bug 23702 - New UNIMARC XSLT according to last IFLA updates
Comment 18 Katrin Fischer 2019-11-22 22:34:21 UTC
Is this still work in progress? (Status: Assigned)
Comment 19 Julian Maurice 2019-11-25 08:50:14 UTC
I guess the status should be needs signoff, but there are some problems in the patch:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetResults.xsl
   FAIL   xml_valid
                266: parser error : Entity 'nbsp' not defined        
                88: parser error : Entity 'nbsp' not defined
                73: parser error : Entity 'nbsp' not defined

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl
   FAIL   xml_valid
                447: parser error : Opening and ending tag mismatch: for-each line 180 and when
                224: parser error : Opening and ending tag mismatch: when line 184 and if
                497: parser error : Opening and ending tag mismatch: stylesheet line 3 and span
                446: parser error : Opening and ending tag mismatch: span line 181 and xsl:if
                496: parser error : Opening and ending tag mismatch: template line 179 and choose
                225: parser error : Opening and ending tag mismatch: choose line 183 and when
                498: parser error : Extra content at the end of the document
Comment 20 delaye 2019-12-03 15:41:40 UTC
Created attachment 95949 [details]
Intranet xslt result new version

  change with  
Comment 21 Koha Team University Lyon 3 2020-01-19 15:59:54 UTC
Thanks Stéphane for the new file UNIMARCslim2intranetResults.xsl.
But according to Julian's comment (comment 19 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702#c19), there's also a problem on the file koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl

I change the previous one to put it "obsolete".
Comment 22 delaye 2020-01-20 14:30:41 UTC
Created attachment 97625 [details]
OPAX -xslt utils
Comment 23 Koha Team University Lyon 3 2020-01-23 16:57:10 UTC
Created attachment 97830 [details]
Bug 23702 - New UNIMARC XSLT according to last IFLA updates
Comment 24 Koha Team University Lyon 3 2020-01-23 17:24:54 UTC
Tried to apply the patch on a sandbox but it seems that there still some issues on the xslt files :
- I don't see any bilbio information on the result pages (just place hold, request articles..)
- in the detail page on intranet the link to see the biblio in the OPAC doesn't work
Comment 25 delaye 2020-03-23 10:50:09 UTC
Created attachment 101417 [details]
xslt opac

new xslt opac
Comment 26 delaye 2020-03-23 10:51:30 UTC
Created attachment 101418 [details]
xslt intranet

new xslt intranet
Comment 27 Koha Team University Lyon 3 2020-04-21 13:47:37 UTC
Created attachment 103375 [details] [review]
Bug 23702 - New UNIMARC XSLT according to last IFLA updates
Comment 28 Fridolin Somers 2020-08-20 09:34:36 UTC
You may integrate changes from Bug 26032
Comment 29 Koha Team University Lyon 3 2020-08-20 09:43:57 UTC
Hello Frido,
I'm not sure to see what we should do with the change in BZ26032 as it's not the same files changed.
But, it's surely over my understanding of what BZ26032 is going to change..
Sonia
Comment 30 Katrin Fischer 2020-09-13 18:34:34 UTC
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23702 - New UNIMARC XSLT according to last IFLA updates
.git/rebase-apply/patch:325: trailing whitespace.
</xsl:call-template> 
.git/rebase-apply/patch:448: trailing whitespace.
<xsl:if test="marc:datafield[@tag=531]"> 
.git/rebase-apply/patch:538: trailing whitespace.
 
.git/rebase-apply/patch:553: trailing whitespace.
 
.git/rebase-apply/patch:601: trailing whitespace.
 
warning: squelched 36 whitespace errors
warning: 41 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl
M	koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl
.git/rebase-apply/patch:325: trailing whitespace.
</xsl:call-template> 
.git/rebase-apply/patch:448: trailing whitespace.
<xsl:if test="marc:datafield[@tag=531]"> 
.git/rebase-apply/patch:538: trailing whitespace.
 
.git/rebase-apply/patch:553: trailing whitespace.
 
.git/rebase-apply/patch:601: trailing whitespace.
 
warning: squelched 36 whitespace errors
warning: 41 lines applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl
CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23702 - New UNIMARC XSLT according to last IFLA updates
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-23702---New-UNIMARC-XSLT-according-to-last-IFL-dGv0oX.patch