Bug 23803 - Add Font Awesome icon to cart in staff interface
Summary: Add Font Awesome icon to cart in staff interface
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Claire Gravely
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-11 12:20 UTC by Claire Gravely
Modified: 2019-10-11 13:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.11.00


Attachments
Bug 23803: Add Font Awesome icon to cart in staff interface (1.88 KB, patch)
2019-10-11 12:25 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 23803: Add Font Awesome icon to cart in staff interface (1.95 KB, patch)
2019-10-11 12:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 23803: Add Font Awesome icon to cart in staff interface (2.01 KB, patch)
2019-10-11 12:41 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 23803: (follow-up) Remove additional references and file (2.15 KB, patch)
2019-10-11 12:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 23803: (follow-up) Remove additional references and file (2.21 KB, patch)
2019-10-11 12:44 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Claire Gravely 2019-10-11 12:20:13 UTC
The cart icon should be a font awesome icon to match the other icons used in Koha.
Comment 1 Claire Gravely 2019-10-11 12:25:22 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2019-10-11 12:32:08 UTC
Created attachment 94010 [details] [review]
Bug 23803: Add Font Awesome icon to cart in staff interface

This patch adds the font awesome icon to the cart in the staff
interface.

To test:

1. Apply patch and run yarn build (see:
 https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

2. Check that the old cart icon no longer displays and the new font
   awesome icon is positioned correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Nick Clemens 2019-10-11 12:41:00 UTC
Created attachment 94012 [details] [review]
Bug 23803: Add Font Awesome icon to cart in staff interface

This patch adds the font awesome icon to the cart in the staff
interface.

To test:

1. Apply patch and run yarn build (see:
 https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client)

2. Check that the old cart icon no longer displays and the new font
   awesome icon is positioned correctly

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Owen Leonard 2019-10-11 12:42:18 UTC
Created attachment 94013 [details] [review]
Bug 23803: (follow-up) Remove additional references and file

This patch removes the cart-small.gif file and a couple other references
to the file.
Comment 5 Nick Clemens 2019-10-11 12:44:44 UTC
Created attachment 94014 [details] [review]
Bug 23803: (follow-up) Remove additional references and file

This patch removes the cart-small.gif file and a couple other references
to the file.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Martin Renvoize 2019-10-11 13:37:06 UTC
Nice work!

Pushed to master for 19.11.00