Bug 23821 - Reintroduction of create_helper_biblio
Summary: Reintroduction of create_helper_biblio
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 7614 21798
Blocks:
  Show dependency tree / graph
 
Reported: 2019-10-16 10:25 UTC by Jonathan Druart
Modified: 2020-06-04 20:35 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
19.11.00
Circulation function:

Attachments
Bug 23821: Remove new occurrence of create_helper_biblio (9.52 KB, patch)
2019-10-16 10:26 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 23821: Remove new occurrence of create_helper_biblio (9.57 KB, patch)
2019-10-16 13:39 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-10-16 10:25:32 UTC 
create_helper_biblio subroutines have been remove from bug 21798, but one occurrence have been reintroduced by bug 7614. We must use build_sample_biblio instead.
Comment 1 Jonathan Druart 2019-10-16 10:26:47 UTC 
Created attachment 94270 [details] [review]
Bug 23821: Remove new occurrence of create_helper_biblio

create_helper_biblio subroutines have been remove from bug 21798, but
one occurrence have been reintroduced by bug 7614. We must use
build_sample_biblio instead.

Test plan:
  prove t/db_dependent/Koha/Libraries.t
should return green.
Comment 2 Tomás Cohen Arazi (tcohen) 2019-10-16 13:39:24 UTC 
Created attachment 94296 [details] [review]
Bug 23821: Remove new occurrence of create_helper_biblio

create_helper_biblio subroutines have been remove from bug 21798, but
one occurrence have been reintroduced by bug 7614. We must use
build_sample_biblio instead.

Test plan:
  prove t/db_dependent/Koha/Libraries.t
should return green.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Martin Renvoize (ashimema) 2019-10-17 13:54:50 UTC 
Nice work!

Pushed to master for 19.11.00