Bug 23853 - Typo in authorised_values.tt
Summary: Typo in authorised_values.tt
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-21 14:22 UTC by Caroline Cyr La Rose
Modified: 2019-10-29 12:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.11.00


Attachments
Bug 23853: Typo in authorised_values.tt (1.56 KB, patch)
2019-10-21 15:15 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 23853: Typo in authorised_values.tt (1.71 KB, patch)
2019-10-29 08:38 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 23853: Typo in authorised_values.tt (1.77 KB, patch)
2019-10-29 12:06 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2019-10-21 14:22:17 UTC
When you go into Administration > Authorised values, there are descriptions for each auth value category. The description of Bsort1 says that it is used for sort 2 field. It should say that it is used for sort 1.

I also noticed that Asort1 and Asort2 have the same description, but Bsort1 and Bsort2 do not.
Comment 1 Caroline Cyr La Rose 2019-10-21 15:15:08 UTC
Created attachment 94454 [details] [review]
Bug 23853: Typo in authorised_values.tt

This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's.

To test:
1- Go to Administration > Authorised values
2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)
Comment 2 Séverine Queune 2019-10-29 08:38:29 UTC
Created attachment 94820 [details] [review]
Bug 23853: Typo in authorised_values.tt

This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's.

To test:
1- Go to Administration > Authorised values
2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Comment 3 Séverine Queune 2019-10-29 08:41:01 UTC
Nice catch Caroline !
Works fine for me :)
Comment 4 Martin Renvoize 2019-10-29 12:06:21 UTC
Created attachment 94828 [details] [review]
Bug 23853: Typo in authorised_values.tt

This patch corrects the Bsort1 typo in authorised_values.tt and changes the Bsort2 description to match Bsort1's.

To test:
1- Go to Administration > Authorised values
2- Make sure descriptions for Bsort1 and Bsort2 match their category and are the same (except for 1 and 2)

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2019-10-29 12:06:37 UTC
Good catch, passing QA
Comment 6 Martin Renvoize 2019-10-29 12:17:08 UTC
Nice work!

Pushed to master for 19.11.00