To Test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl - Confirm patron correctly shows "Yes" on memberentry.pl and opac-privacy.pl - Confirm patron correctly shows privacy_guarantor_checkouts=1 in database
This is ok on master.
19.05: [% IF privacy_guarantor_checkouts %] master: [% IF patron.privacy_guarantor_checkouts %] 19.11: [% IF patron.privacy_guarantor_checkouts %] I'll provide a patch.
Created attachment 105301 [details] [review] Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly
Please, rebase this bug on master. Thank you.
(In reply to Michal Denar from comment #4) > Please, rebase this bug on master. > > Thank you. This patch is for 19.05 only.
Created attachment 106422 [details] [review] Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
It works! :) A guess of the continuation of the process would be: - QA as usual - instead of the RM to push to master, it would be the RMaint of 19.05.x (turns out to be me)
Created attachment 106502 [details] [review] Bug 24353: [19.05] Correct display of privacy_guarantor_checkouts on moremember.pl The variable for 'Show checkouts to guarantor' was incorrect so it would always show as 'No' on the Details tab in the patron account in staff. To test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl (Details tab) - Apply patch - Confirm the display changes to "Yes" - Change the value to "No" in the patron record - Verify that the display changed accordingly Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Pushed to 19.05.x branch for 19.05.13, thanks to everyone involved! :D