koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [#% Default branch %#] koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt: [#% Branch-specific %#] but TT comments are [%# Go to admin/smart-rules.pl and search the page source, you'll find those strings in there.
Created attachment 100143 [details] [review] Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none.
Created attachment 100177 [details] [review] Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 100212 [details] [review] Bug 24798: smart-rules.tt has erroneous comments This patch corrects a couple of invalid Template Toolkit comments in the Circulation and Fines rules template. To test, apply the patch and log into the staff client as an administrator. On the Circulation and Fines Rules page "View source" and look for instances of the text "[#% Default branch %#]" There should be none. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] There is a theoretical difference between [% # and [%#. The latter marks the whole directive as a comment and not just until EOL.
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.05
backported to 19.05.x for 19.05.10
Backported to 18.11.x for 18.11.16