Some attribute mappings from the RFC were missed on bug 18731: authorisedby => 'creator_id', deliveryplace => 'delivery_library_id', billingplace => 'billing_library_id',
Created attachment 101318 [details] [review] Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket When bug 18731 was written, the official vote on the RFC hadn't been held yet. Once it got voted, the mappings were adapted and all the dependent work fixed as well. But three attribute names were overlooked and they become evident on developing 20212 which required them. This patch fixes this really tiny mistake. To test: 1. Just verify the voted attribute names. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 101319 [details] [review] Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket When bug 18731 was written, the official vote on the RFC hadn't been held yet. Once it got voted, the mappings were adapted and all the dependent work fixed as well. But three attribute names were overlooked and they become evident on developing 20212 which required them. This patch fixes this really tiny mistake. To test: 1. Just verify the voted attribute names. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 101412 [details] [review] Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket When bug 18731 was written, the official vote on the RFC hadn't been held yet. Once it got voted, the mappings were adapted and all the dependent work fixed as well. But three attribute names were overlooked and they become evident on developing 20212 which required them. This patch fixes this really tiny mistake. To test: 1. Just verify the voted attribute names. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
not backported to 19.11.x