We have this logic for searching rentaldiscount rule https://github.com/Koha-Community/Koha/blob/6ac037f817def256c85706413036bee3f78ed40e/C4/Circulation.pm#L3304-L3326 Why? This is against documentation on sorting order of circulation rules in the user interface. Use Koha::CirculationRules->get_effective_rule() instead.
Created attachment 102769 [details] [review] Bug 25115: Use get_effective_rule for getting rental discount
Added a proposed patch if this Bug is valid. GetIssuingCharges() seems to have no unit test, could someone generate one for this? :)
Can you please provide a test plan for the patch?
*** This bug has been marked as a duplicate of bug 26593 ***