I think it would be useful for the OPAC cart window's toolbar to float.
Created attachment 103670 [details] [review] Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons.
For me, it works except in More details view as you can see here: https://youtu.be/-z0nZ0oLyGs
(In reply to Frédéric Demians from comment #2) > For me, it works except in More details view as you can see here: This is the same problem I had without the patch for Bug 25274. Did you test with that patch applied?
Created attachment 103777 [details] [review] Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(In reply to Owen Leonard from comment #3) > This is the same problem I had without the patch for Bug 25274. Did you test > with that patch applied? That's it. It works with this patch (it wasn't yet pushed on master this morning when I tested...)
QA script complains a bit, but this will be fixed by bug 25166 - so I suggest we forego a follow-up here. FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt OK filters FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 23) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 25) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 28) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 30) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 31) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 32) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 34) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 44) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 47) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 50) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 53)
Created attachment 103881 [details] [review] Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Sorry Owen.. not sure which bug I just pushed that breaks this, but the rebase looks like your expert eyes would do better than mine in this case.. pretty please.
Created attachment 103970 [details] [review] Bug 25271: Add floating toolbar to OPAC cart This patch adds JavaScript to the OPAC cart view so that the toolbar at the top of the display "floats" as you scroll down. The patch also makes a minor correction to the OPAC SCSS affecting the display of the buttons in the cart toolbar. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Add some items to a cart in the OPAC. - Open the cart and confirm that the toolbar sticks to the top of the window as you scroll down. - Confirm that it works in the "More details" view. - Confirm that other JavaScript-based operations are not affected: table sorting and all the various toolbar buttons. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11