In the "Library use" section on the Details page for a patron for an expired/epiring patron, the "Edit details" link uses op=modify], which looks like it works (ie it doesn't explode), but it doesn't work.
Created attachment 103820 [details] [review] Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details
Created attachment 103821 [details] [review] Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details Signed-off-by: Frédéric Demians <f.demians@tamil.fr> See the typo, the bug before/after
Thanks, Frédéric!
Created attachment 103878 [details] [review] Bug 25300: Fix typo in "Edit details" for expiring/expired patron This patch removes a typo in the argument to the "op" parameter for the "Edit details" link when editing an expiring/expired patron on the Details page. Test plan: 0. Do not apply patch yet 1. Create patron 2. Set expiry date to 3 days from now 3. Go to Details tab in patron record 4. Click "Edit details" in "Library use" section 5. Note the form is blank and has no patron data in it 6. Apply the patch 7. Reload the Details page in patron record 8. Click "Edit details" in "Library use" section 9. Note the form now contains your patron data and will work for editing the details Signed-off-by: Frédéric Demians <f.demians@tamil.fr> See the typo, the bug before/after Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06
backported to 19.05.x for 19.05.11