In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 --
Created attachment 104791 [details] [review] Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks!
Created attachment 104792 [details] [review] Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks!
Created attachment 104854 [details] [review] Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 104923 [details] [review] Bug 25468: Preserve line breaks in hold notes In a hold note, line breaks are not preserved when viewing the note. A note like: -- Test 1 Test 2 -- will be rendered as: -- Test 1 Test 2 -- Test Plan: 1) Place a hold with a note, use line breaks in the note. 2) Note the lines all run together when viewing the hold. 3) Apply this patch. 4) Reload the page. 5) Notes should now display with the original line breaks! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
@RM: Touches a template but should not result in translation changes. Just a %s ;)
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x for 19.11.06