Bug 25523 - Address lintian warnings when packaging Koha
Summary: Address lintian warnings when packaging Koha
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-18 06:18 UTC by David Cook
Modified: 2022-04-04 23:27 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2020-05-18 06:18:11 UTC
I notice that lintian raises a lot of warnings when building Koha packages.

Some of these like the following can be safely ignored:
W: koha-common: embedded-javascript-library usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js please use libjs-jquery-cookie
W: koha-common: embedded-javascript-library usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.metadata.min.js please use libjs-jquery-metadata

But then there are others that would be easy wins:
W: koha-common: executable-not-elf-or-script usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
W: koha-common: executable-not-elf-or-script usr/share/koha/lib/C4/HoldsQueue.pm
W: koha-common: executable-not-elf-or-script usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/subtag_registry.sql

I'm thinking about slowly tackling these...
Comment 1 David Cook 2020-05-18 06:18:22 UTC
Now running lintian...
E: koha changes: changed-by-address-malformed Mirko Tietgen <koha@ac0fcad5a8f3>
E: koha source: source-is-missing koha-tmpl/opac-tmpl/lib/hc-sticky.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/require.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/hc-sticky.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/lib/verovio/verovio-toolkit.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/lib/verovio/000_acoustic_grand_piano.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/fontfaceobserver.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/js/browserid_include.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/tinymce.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/jquery.tinymce.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/moment/moment.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/moment/moment-timezone-with-data-10-year-range.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/linters/jshint.js
E: koha source: license-problem-json-evil koha-tmpl/intranet-tmpl/lib/linters/jshint.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/linters/htmlhint.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/leaflet/leaflet.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/jquery.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/jquery-ui.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/d3c3/d3.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/d3c3/c3.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/codemirror/codemirror.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/bootstrap/bootstrap.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.dataTables.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/lib/jquery/plugins/jquery.barrating.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/lib/emoji-picker/js/emoji-picker-all.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/yui/yahoo-dom-event/yahoo-dom-event.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/yui/utilities/utilities.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/yui/plugins/loading-min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/yui/plugins/bubbling-min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/yui/element/element-beta-min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/yui/button/button-beta-min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/select2/js/select2.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/layouts/all.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/languages/all.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.mousewheel.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-typing.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-scramble.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-previewkeyset.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-navigation.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-mobile.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-extender.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-caret.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-autocomplete.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-altkeyspopup.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/keyboard/js/jquery.keyboard.extension-all.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jszip.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.validate.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.jeditable.mini.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.cookie.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery.checkboxes.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/jquery-ui-timepicker-addon.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.validate.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.metadata.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.hoverIntent.minified.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.deserialize.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js
E: koha source: source-is-missing koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.checkboxes.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/themes/silver/theme.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/themes/mobile/theme.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/table/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/lists/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/link/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/image/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/hr/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/emoticons/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/code/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/charmap/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/tiny_mce/plugins/autoresize/plugin.min.js
E: koha source: source-is-missing koha-tmpl/intranet-tmpl/lib/jquery/plugins/rowGroup/dataTables.rowGroup.min.js
W: koha source: debhelper-but-no-misc-depends koha-perldeps
W: koha source: maintainer-script-lacks-debhelper-token debian/koha-common.preinst
W: koha source: package-needs-versioned-debhelper-build-depends 9
W: koha source: changelog-should-mention-nmu
W: koha source: source-nmu-has-incorrect-version-number 19.12.00-test+20200518060943.48a23774-1
E: koha source: untranslatable-debconf-templates koha-common.templates: 3
E: koha source: untranslatable-debconf-templates koha-common.templates: 15
E: koha source: untranslatable-debconf-templates koha-common.templates: 22
E: koha source: not-using-po-debconf
W: koha source: ancient-standards-version 3.8.4 (current is 3.9.6)
E: koha-perldeps: debian-changelog-file-contains-invalid-email-address koha@ac0fcad5a8f3
W: koha: apache2-reverse-dependency-uses-obsolete-directory etc/apache2/conf.d/koha
W: koha: non-standard-apache2-configuration-name koha != koha.conf
E: koha: apache2-reverse-dependency-ships-file-in-not-allowed-directory etc/apache2/sites-enabled/koha
E: koha: debian-changelog-file-contains-invalid-email-address koha@ac0fcad5a8f3
W: koha: file-in-unusual-dir var/spool/koha/README
E: koha-deps: debian-changelog-file-contains-invalid-email-address koha@ac0fcad5a8f3
W: koha-deps: virtual-package-depends-without-real-package-depends depends: cron-daemon
E: koha-common: debian-changelog-file-contains-invalid-email-address koha@ac0fcad5a8f3
W: koha-common: malformed-question-in-templates koha-common/automatically-update-translations
W: koha-common: making-assumptions-about-interfaces-in-templates koha-common/automatically-update-translations
W: koha-common: virtual-package-depends-without-real-package-depends depends: cron-daemon
W: koha-common: duplicate-font-file usr/share/koha/intranet/htdocs/intranet-tmpl/lib/font-awesome/fonts/FontAwesome.otf also in fonts-font-awesome
W: koha-common: duplicate-font-file usr/share/koha/intranet/htdocs/intranet-tmpl/lib/font-awesome/fonts/fontawesome-webfont.ttf also in fonts-font-awesome
W: koha-common: extra-license-file usr/share/koha/intranet/htdocs/intranet-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt
W: koha-common: embedded-javascript-library usr/share/koha/intranet/htdocs/intranet-tmpl/lib/jquery/jquery.js please use libjs-jquery
W: koha-common: embedded-javascript-library usr/share/koha/intranet/htdocs/intranet-tmpl/lib/jquery/plugins/jquery.cookie.min.js please use libjs-jquery-cookie
W: koha-common: extra-license-file usr/share/koha/intranet/htdocs/intranet-tmpl/lib/jquery/plugins/multiple-select/LICENSE
W: koha-common: embedded-javascript-library usr/share/koha/intranet/htdocs/intranet-tmpl/lib/jquery/plugins/treetable/jquery.treetable.js please use libjs-jquery-treetable
W: koha-common: embedded-javascript-library usr/share/koha/intranet/htdocs/intranet-tmpl/lib/keyboard/js/jquery.mousewheel.min.js please use libjs-jquery-mousewheel
W: koha-common: embedded-javascript-library usr/share/koha/intranet/htdocs/intranet-tmpl/lib/yui/yahoo-dom-event/yahoo-dom-event.js please use libjs-yui
W: koha-common: duplicate-font-file usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/font-awesome/fonts/FontAwesome.otf also in fonts-font-awesome
W: koha-common: duplicate-font-file usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/font-awesome/fonts/fontawesome-webfont.ttf also in fonts-font-awesome
W: koha-common: extra-license-file usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/greybox/GreyBox_v5_5/LGPL.txt
W: koha-common: embedded-javascript-library usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min.js please use libjs-jquery-cookie
W: koha-common: embedded-javascript-library usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.metadata.min.js please use libjs-jquery-metadata
E: koha-common: dir-or-file-in-var-lock var/lock/koha/
E: koha-common: duplicate-updaterc.d-calls-in-postinst koha-common
W: koha-common: manpage-has-errors-from-man usr/share/man/man8/koha-plack.8.gz 34: warning [p 1, 1.5i]: can't break line
W: koha-common: binary-without-manpage usr/sbin/koha-enable-sip
W: koha-common: binary-without-manpage usr/sbin/koha-passwd
W: koha-common: binary-without-manpage usr/sbin/koha-post-install-setup
W: koha-common: binary-without-manpage usr/sbin/koha-restart-zebra
W: koha-common: binary-without-manpage usr/sbin/koha-start-sip
W: koha-common: binary-without-manpage usr/sbin/koha-start-zebra
W: koha-common: binary-without-manpage usr/sbin/koha-stop-sip
W: koha-common: binary-without-manpage usr/sbin/koha-stop-zebra
W: koha-common: binary-without-manpage usr/sbin/koha-z3950-responder
W: koha-common: script-not-executable etc/bash_completion.d/koha-common
W: koha-common: script-not-executable etc/koha/plack.psgi
W: koha-common: script-not-executable usr/share/koha/bin/cronjobs/update_patrons_category.pl
W: koha-common: script-not-executable usr/share/koha/bin/load_testing/benchmark_staff.pl
W: koha-common: script-not-executable usr/share/koha/bin/maintenance/compare_es_to_db.pl
W: koha-common: script-not-executable usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/EXAMPLE.pl
W: koha-common: script-not-executable usr/share/koha/intranet/cgi-bin/svc/letters/preview
W: koha-common: executable-not-elf-or-script usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/admin/additional-fields.tt
W: koha-common: executable-not-elf-or-script usr/share/koha/lib/C4/HoldsQueue.pm
W: koha-common: executable-not-elf-or-script usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/subtag_registry.sql
Finished running lintian.