The actual way that the Acq table appears in the basket view (basket.pl), 1.Basket # 2. Order information 3. RRP Tax Exc 4. Actual Cost Exc 5. Budgeted Cost Tax Exc 6. RRP Tax Included 7. Actual Cost Tax Inc 8. Budgeted Cost Tax Inc 9. Replacement Price 10. Quantity But in the column config table 1.Basket # 2. Order Info 3. RRP tax Exc 4. Ecost Exc (Actual Exc) 5. RRP tax Included 6. Ecost Tax Included (Actual Inc) 7. Replacement Prie 8. Quantity 9. Total Tax Excluded 10. Total Tax Included We will need to change the column configuration to match the table so it is easy to hide the correct columns.
Created attachment 105235 [details] [review] Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice!
> 1. Go to Acquisitions and look at basket.pl Is and individual basket? "Home › Acquisitions › My Vendor › Basket My Basket (1) for My Vendor " Assuming yes. > 2. Open another tab and go to column configuration and try to hide some columns like Quantity. > 3. See that the wrong columns are being hidden. Can't reproduce. I tried to hide and show most of the columns and nothing seemed wrong. (not sure if relevant, Quantity is hidden by default, no idea where the setting is) What is the role of opening another tab?
Victor, Thanks for testing. Are you attempting to hide/show the columns by using the column configuration tool? The only reason I said 'open a new tab' is so the tester can have the column configuration tool open in one tab and the table in another. To make it easier to test.
(In reply to Lucas Gass from comment #3) > Are you attempting to hide/show the columns by using the column > configuration tool? Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png
> Is that this thing? https://picat.drycat.fr/gallery#ZxsjxojK/D7urRk7F.png Victor, No, I am referring to the Configure columns tool at Koha Admin > Configure columns. /cgi-bin/koha/admin/columns_settings.pl https://snipboard.io/Hk0N7V.jpg
Created attachment 105421 [details] [review] Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
(In reply to Lucas Gass from comment #5) > No, I am referring to the Configure columns tool at Koha Admin > Configure > columns. > > /cgi-bin/koha/admin/columns_settings.pl > > https://snipboard.io/Hk0N7V.jpg Hooooooo > 3. See that the wrong columns are being hidden. Indeed, nonsense can happen! > 6. Rejoice! It works! :D
Created attachment 105425 [details] [review] k
Created attachment 105426 [details] [review] Bug 25557: Correct basket.pl column config This patch corrects the column configuration tool for basket.pl TO TEST: 1. Go to Acquisitions and look at basket.pl 2. Open another tab and go to column configuration and try to hide some columns like Quantity. 3. See that the wrong columns are being hidden. 4. Apply patch 5. Trying hiding each column in the table and make sure the correct one is being hidden. 6. Rejoice! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
*** Bug 25714 has been marked as a duplicate of this bug. ***
Pushed to master for 20.11, thanks to everybody involved!
backported to 20.05.x for 20.05.01
backported to 19.11.x for 19.11.07
Backported to 19.05.x branch for 19.05.12