Bug 25572 - Permissions for Mana Reports are currently linked to Permissions in Serials
Summary: Permissions for Mana Reports are currently linked to Permissions in Serials
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Mana-kb (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 17047
Blocks: 27061
  Show dependency treegraph
 
Reported: 2020-05-21 19:35 UTC by Kelly McElligott
Modified: 2020-11-20 16:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 25572: Fix permission check for mana (reports) (2.22 KB, patch)
2020-11-20 08:01 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 25572: Fix permission check for mana (reports) (2.28 KB, patch)
2020-11-20 16:47 UTC, Kelly McElligott
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2020-05-21 19:35:09 UTC
Mana works with both Reports and Serials.  Currently a staff member needs to have a serial permissions to be able to use the Mana function in the reporting module. If the staff member does not have the permission, "Create A New Subscription", the staff member can not use Mana in the reports module.
Comment 1 Jonathan Druart 2020-05-22 08:20:44 UTC
From svc/mana/search:
 32 my ( $auth_status, $sessionID ) =
 33   check_cookie_auth( $input->cookie('CGISESSID'),
 34     { serials => 'create_subscription' } );

Not sure how we can fix this correctly.
Comment 2 Andrew Fuerste-Henry 2020-11-19 17:21:23 UTC
+1 on this, folks don't like having to give extra permissions for stuff like this to work.
Comment 3 Jeff Gaines 2020-11-19 17:24:03 UTC
Yes, I have staff that do nothing with Serials but are heavy report users.
Comment 4 Jonathan Druart 2020-11-20 08:01:26 UTC
Created attachment 113865 [details] [review]
Bug 25572: Fix permission check for mana (reports)

Mana works with both Reports and Serials.
Currently a staff member needs to have a serial permissions to be able to use the
Mana function in the reporting module. If the staff member does not have the
permission, "Create A New Subscription", the staff member can not use Mana in the
reports module.

Test plan:
Enable Mana
Create a patron with the "create new subscription" permission
Create another patron with the "create new report" permission
Confirm that both can use Mana in their respective module.
Comment 5 Kelly McElligott 2020-11-20 16:47:12 UTC
Created attachment 113899 [details] [review]
Bug 25572: Fix permission check for mana (reports)

Mana works with both Reports and Serials.
Currently a staff member needs to have a serial permissions to be able to use the
Mana function in the reporting module. If the staff member does not have the
permission, "Create A New Subscription", the staff member can not use Mana in the
reports module.

Test plan:
Enable Mana
Create a patron with the "create new subscription" permission
Create another patron with the "create new report" permission
Confirm that both can use Mana in their respective module.

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com	>