Bug 26164 - Replace OPAC table sort icons with SVG
Summary: Replace OPAC table sort icons with SVG
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 20168
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-06 15:49 UTC by Owen Leonard
Modified: 2020-09-18 00:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 26164: Replace OPAC table sort icons with SVG (6.32 KB, patch)
2020-09-09 13:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 26164: Replace OPAC table sort icons with SVG (6.37 KB, patch)
2020-09-18 00:30 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2020-08-06 15:49:19 UTC
Like Bug 26060: DataTables in the OPAC have sorting icons added to the headers via a background PNG image. I suggest we replace these with data-url SVG images which will look better, especially on higher-resolution screens or at higher zoom settings.
Comment 1 Owen Leonard 2020-09-09 13:59:48 UTC
Created attachment 109817 [details] [review]
Bug 26164: Replace OPAC table sort icons with SVG

This patch modifies the OAPC CSS to convert table sorting icons from PNG
to SVG. These icons are added via background-image data-urls, so only
the SCSS file is modified.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).

- Clear your browser cache if necessary
- View any DataTable in the OPAC, for instance the table of
  checkouts under the logged-in user's "your summary" tab.
- Confirm that the sorting icons in the table headers look
  correct in each state: Sorted ascending, sorted descending, and
  unsorted.
Comment 2 David Nind 2020-09-18 00:30:28 UTC
Created attachment 110309 [details] [review]
Bug 26164: Replace OPAC table sort icons with SVG

This patch modifies the OAPC CSS to convert table sorting icons from PNG
to SVG. These icons are added via background-image data-urls, so only
the SCSS file is modified.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).

- Clear your browser cache if necessary
- View any DataTable in the OPAC, for instance the table of
  checkouts under the logged-in user's "your summary" tab.
- Confirm that the sorting icons in the table headers look
  correct in each state: Sorted ascending, sorted descending, and
  unsorted.

Signed-off-by: David Nind <david@davidnind.com>