Created attachment 108801 [details] [review] Bug 26267: Add jQuery validator to memberentrygen.tt To test: 1) Initiate password recovery. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off.
Looks good, but it's not necessary to have the $(document).ready part: $(document).ready(function() { $("#entryform").validate({ It's already inside a $(document).ready block.
(In reply to Owen Leonard from comment #2) > Looks good, but it's not necessary to have the $(document).ready part: > > $(document).ready(function() { > $("#entryform").validate({ > > It's already inside a $(document).ready block. Thank you for pointing it out so kindly.
Created attachment 108976 [details] [review] Bug 26267: Add jQuery validator to memberentrygen.tt To test: 1) Add a new patron. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off.
Created attachment 108983 [details] [review] Bug 26267: Add jQuery validator to memberentrygen.tt To test: 1) Add a new patron. 2) Try to enter an invalid password. 3) Confirm that validation occurs. 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. 6) Sign off. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Hi, I don't understand what this patch does, If I try to do steps 4) Try to enter mismatching passwords. 5) Confirm that validation occurs. in the page /cgi-bin/koha/members/memberentry.pl I have the same result "Please enter the same password as above" with and without this patch. Is the difference somewhere else / how I confirm validation happens?
I see now that in memberentrygen.tt that the validator is already included like this: [% Asset.js("js/members.js") | $raw %] Rather than inline, like in the other templates.